-
Notifications
You must be signed in to change notification settings - Fork 59
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
vdk-impala: support also pydantic 1.0 (#2368)
Ensure vdk-impala works with pydantic 1.0 as this is still used and libraries do not support the new version. In hindsight, I should have pinned to 1.0 only. But I did not and it's a good idea to support the new version otherwise at some point it will cause conflicts and problems as other libraries adopt 2.0 of pydantic Testing Done: installed locally pydantic 1.0 . The Gitlab CI is testing with 2 - `pip install pydantic==1.*` - ../build-plugin.sh (from vdk-impala dir) - verified the test exited successfully. I toyed with the idea of adding a test for pydanitc 1.0 but it would require some refactoring of hte plugin framework to allow that and it's not that urgent as the changes are fairly small.
- Loading branch information
1 parent
1f18b58
commit 87fa46a
Showing
2 changed files
with
34 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,5 @@ | ||
|
||
# testing requirements | ||
click | ||
docker-compose | ||
impyla | ||
pyarrow | ||
pydantic | ||
pytest-docker | ||
tabulate | ||
vdk-core | ||
vdk-lineage-model | ||
vdk-test-utils |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters