-
Notifications
You must be signed in to change notification settings - Fork 59
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
control-service: make image registry configurable
Our build images are currently in dockerhub. Dockerhub imposes limits on number of pulls which can be hit very frequently. Often common solution to this problem to use proxy cache server. From VMware popular one is Harbor (https://goharbor.io/). AWS and Google Cloud offer their own proxy solutions as well. So we should expect that customers would frequently need to configure a proxy. While we want customers to configure proxy we generally do not want them to override the name of the repository and especially the version since these are usually set during release so they match. And if user upgrades the helm chart he'd need to manually bump the versions which is very error prone (and easy to forget). Hence common solution used in many charts (see https://github.com/bitnami/charts/tree/master/bitnami) is to separate registry, repository and tag. Also global.imageRegistry enables users to specify the proxy registry just once and not for every chart. That makes it forward-compatible (in other words if we add new image it would automatically use the proxy cache when users upgrade) Testing Done: helm lint locally passed. Gitlab CI will test it fully. Signed-off-by: Antoni Ivanov <[email protected]>
- Loading branch information
1 parent
7274942
commit 797444b
Showing
3 changed files
with
58 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters