Skip to content

Commit

Permalink
vdk-dag: replace DAG diagrams with consistently colored ones (#2173)
Browse files Browse the repository at this point in the history
What:
Replace DAG diagrams with consistently colored ones.

Why: 
To have a consistent and better-looking docs.

Signed-off-by: Yoan Salambashev <[email protected]>
  • Loading branch information
yonitoo authored May 31, 2023
1 parent c87fe40 commit 4220970
Show file tree
Hide file tree
Showing 7 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions examples/dag-example/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -439,8 +439,8 @@ vdk deploy -n ingest-job2 -t my-team -p ingest-job2 -r "dag-example" -u http://l
```

```console
vdk create -n read-job -t my-team --no-template -u http://localhost:8092 && \
vdk deploy -n read-job -t my-team -p read-job -r "dag-example" -u http://localhost:8092
vdk create -n read-data-job -t my-team --no-template -u http://localhost:8092 && \
vdk deploy -n read-data-job -t my-team -p read-data-job -r "dag-example" -u http://localhost:8092
```

```console
Expand Down
Binary file modified examples/dag-example/images/dag-graph.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified examples/dag-with-args-example/images/dag.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion projects/vdk-plugins/vdk-dag/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ When defining a job to be run following attributes are supported:
The following example dependency graph can be implemented with below code.


![img_2.png](img_2.png)
![example_dag.png](example_dag.png)

In this example what happens is:
* Job 1 will execute.
Expand Down
Binary file added projects/vdk-plugins/vdk-dag/example_dag.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file removed projects/vdk-plugins/vdk-dag/img_2.png
Binary file not shown.
Binary file modified specs/vep-1243-vdk-dag/sample-execution.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit 4220970

Please sign in to comment.