Skip to content

Commit

Permalink
frontend: remove e2e tests restrictions (#2386)
Browse files Browse the repository at this point in the history
## Why?

Since the e2e tests have been moved to the pre_release_test stage, the
pipeline might fail under certain conditions, e.g. changes to CI-related
files


https://gitlab.com/vmware-analytics/versatile-data-kit/-/pipelines/927407847

## What?

Trigger e2e tests on all shared and data-pipelines locations. The
behavior should be the same as for the build stage

## How was this tested?

CI

## What kind of change is this?

Bugfix

Signed-off-by: Dilyan Marinov <[email protected]>
  • Loading branch information
DeltaMichael authored Jul 11, 2023
1 parent 7cf915e commit 18ac507
Showing 1 changed file with 2 additions and 11 deletions.
13 changes: 2 additions & 11 deletions projects/frontend/cicd/.gitlab-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,6 @@
- "projects/frontend/cicd/**/*"
- "projects/frontend/data-pipelines/**/*"

.frontend_paths_do_not_trigger_e2e: &frontend_do_not_trigger_e2e
- "projects/frontend/data-pipelines/README.md"
- "projects/frontend/data-pipelines/gui/Dockerfile"
- "projects/frontend/data-pipelines/gui/config/nginx.conf"

.frontend_retry:
retry_options:
max: 1
Expand Down Expand Up @@ -72,14 +67,10 @@ frontend-data-pipelines-e2e-tests:
- ./cicd/test_e2e_data_pipelines.sh "$VDK_API_TOKEN" "$CYPRESS_test_environment" "$CI_PIPELINE_ID" "$CYPRESS_grepTags"
retry: !reference [.retry, retry_options]
rules:
- changes: *frontend_do_not_trigger_e2e
when: never
- if: '$CI_COMMIT_BRANCH == "main" || $CI_PIPELINE_SOURCE == "external_pull_request_event"'
changes:
- "projects/frontend/shared-components/**/*"
changes: *frontend_shared_components_locations
- if: '$CI_COMMIT_BRANCH == "main" || $CI_PIPELINE_SOURCE == "external_pull_request_event"'
changes:
- "projects/frontend/data-pipelines/**/*"
changes: *frontend_data_pipelines_locations
artifacts:
when: always
paths:
Expand Down

0 comments on commit 18ac507

Please sign in to comment.