Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vcfa_edge_cluster + vcfa_edge_cluster_qos #11

Merged
merged 29 commits into from
Jan 24, 2025
Merged

vcfa_edge_cluster + vcfa_edge_cluster_qos #11

merged 29 commits into from
Jan 24, 2025

Conversation

Didainius
Copy link
Collaborator

@Didainius Didainius commented Jan 22, 2025 •
edited
Loading

vcfa_edge_cluster + vcfa_edge_cluster_qos

Additional things:

  • vcfa_region name field has ForceNew: true
  • vCenter refresh operations use runWithRetry for up to two minutes to continue retrying refresh operations if the error matches regex (is currently busy|400|BUSY_ENTITY)
  • Does not try to "sync" edge clusters when the limits are applied because they get reset

Ref:

@Didainius
vcfa_ip_space
1deefc3 
Signed-off-by: Dainius <[email protected]>
@Didainius
Self review
d4ebd88 
Signed-off-by: Dainius <[email protected]>
@Didainius
Add IP Space locking mechanism
be4286a 
Signed-off-by: Dainius <[email protected]>
@Didainius
Remove comment field
11cad5b 
Signed-off-by: Dainius <[email protected]>
@Didainius
vcdMutexKv to vcfaMutexKv
a8a7d6c 
Signed-off-by: Dainius <[email protected]>
@Didainius
WIP
4b9add7 
Signed-off-by: Dainius <[email protected]>
@Didainius
Changelog
b2bfaec 
Signed-off-by: Dainius <[email protected]>
@Didainius
update resource index
4a99fa5 
Signed-off-by: Dainius <[email protected]>
@Didainius
vcfa_edge_cluster + vcfa_edge_cluster_qos
6c8bcf3 
Signed-off-by: Dainius <[email protected]>
@Didainius
Merge main
7ceddd5 
Signed-off-by: Dainius <[email protected]>
@Didainius
Add missing test helper for IP Spaces
4a8a884 
Signed-off-by: Dainius <[email protected]>
@Didainius
Add extra sleep after vCenter ops
86f9222 
Signed-off-by: Dainius <[email protected]>
@Didainius
Name tuning
5c796f7 
Signed-off-by: Dainius <[email protected]>
@Didainius
Patch TestAccDataSourceNotFound/vcfa_tier0_gateway
658da22 
Signed-off-by: Dainius <[email protected]>
@Didainius
Handle broken provider gateway resoruce creation and tainted recovery
0cf9484 
Signed-off-by: Dainius <[email protected]>
@Didainius
Bump govcd
858c4a3 
Signed-off-by: Dainius <[email protected]>
@Didainius
Merge branch 'vcfa_provider_gateway' into vcfa_edge_cluster
c1bc163
@Didainius
Fix broken validations
c8dd55d 
Signed-off-by: Dainius <[email protected]>
@Didainius
Merge main
b260a6e 
Signed-off-by: Dainius <[email protected]>
@Didainius
Fix error
d2842d0 
Signed-off-by: Dainius <[email protected]>
@Didainius
vcfa_region name ForceNew: true, changelog
fa7dc65 
Signed-off-by: Dainius <[email protected]>
@Didainius
Adjust QoS, change approach to vCenter profile refreshes
6e4e324 
Signed-off-by: Dainius <[email protected]>
@Didainius
Update docs
bb92066 
Signed-off-by: Dainius <[email protected]>
@Didainius
Fix TestAccDataSourceNotFound/vcfa_edge_cluster_qos
cad0903 
Signed-off-by: Dainius <[email protected]>
@Didainius Didainius marked this pull request as ready for review January 24, 2025 08:38
lvirbalas
lvirbalas approved these changes Jan 24, 2025
View reviewed changes
Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works beautifully in manual testing.

adambarreiro
adambarreiro approved these changes Jan 24, 2025
View reviewed changes
@Didainius
Address comments
a08125d 
Signed-off-by: Dainius <[email protected]>
@Didainius Didainius merged commit 8239495 into vmware:main Jan 24, 2025
2 checks passed
@Didainius Didainius deleted the vcfa_edge_cluster branch January 24, 2025 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adambarreiro adambarreiro adambarreiro approved these changes

@lvirbalas lvirbalas lvirbalas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Didainius @adambarreiro @lvirbalas