Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove BGP peer password requirement #150

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

dimitarproynov
Copy link
Contributor

In order to have a good experience with our community, we recommend that you read the contributing guidelines for making a pull request.

Summary of Pull Request

Remove BGP peer password requirement
Clients of VCF have a use-case where the BGP peer password is not used.

Type of Pull Request

  • This is a bug fix.
  • This is an enhancement or feature.
  • This is a code style/formatting update.
  • This is a documentation update.
  • This is a refactoring update.
  • This is a chore update
  • This is something else.
    Please describe:

Related to Existing Issues

Issue Number: #146

Test and Documentation Coverage

For bug fixes or features:

  • Tests have been completed.
  • Documentation has been added/updated.

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

Clients of VCF have a use-case where the BGP peer password is not used.

#146

Testing done:
make test
make build
make lint

Signed-off-by: Dimitar Proynov <[email protected]>
@vmwclabot
Copy link
Member

@dimitarproynov, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmwclabot vmwclabot added the dco-required DCO Required label Apr 3, 2024
@github-actions github-actions bot added documentation Documentation needs-review Needs Review provider Provider labels Apr 3, 2024
@dimitarproynov dimitarproynov merged commit 4b58441 into main Apr 3, 2024
7 checks passed
Copy link

github-actions bot commented May 4, 2024

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 4, 2024
@dimitarproynov dimitarproynov deleted the feature/remove_bgp_peer_pass_validation branch May 16, 2024 09:46
@tenthirtyam tenthirtyam removed the needs-review Needs Review label Jun 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dco-required DCO Required documentation Documentation provider Provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants