Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rename incorrect property in edge node example #133

Merged
merged 1 commit into from
Mar 5, 2024
Merged

fix: rename incorrect property in edge node example #133

merged 1 commit into from
Mar 5, 2024

Conversation

spacegospod
Copy link
Contributor

@spacegospod spacegospod commented Feb 28, 2024 •
edited by tenthirtyam
Loading

Summary of Pull Request

Fixes incorrect keys and variables in edge cluster example.

Type of Pull Request

  • This is a bug fix.
  • This is an enhancement or feature.
  • This is a code style/formatting update.
  • This is a documentation update.
  • This is a refactoring update.
  • This is a chore update
  • This is something else.
    Please describe:

Related to Existing Issues

Closes #131

Test and Documentation Coverage

Ran "terraform plan" on the example configuration to make sure there are no more typo's and incorrect keys

For bug fixes or features:

  • Tests have been completed.
  • Documentation has been added/updated.

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

@github-actions github-actions bot added documentation Documentation needs-review Needs Review labels Feb 28, 2024
@spacegospod spacegospod self-assigned this Feb 28, 2024
@tenthirtyam tenthirtyam changed the title Fix incorrect keys and variables in edge cluster example file fix: incorrect keys and variables in edge cluster example file Mar 5, 2024
tenthirtyam
tenthirtyam approved these changes Mar 5, 2024
View reviewed changes
Copy link
Collaborator

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tenthirtyam tenthirtyam changed the title fix: incorrect keys and variables in edge cluster example file fix: incorrect keys and variables in edge cluster example Mar 5, 2024
@tenthirtyam tenthirtyam changed the title fix: incorrect keys and variables in edge cluster example fix: rename incorrect property in edge node example Mar 5, 2024
@tenthirtyam tenthirtyam merged commit 3d3efab into main Mar 5, 2024
10 checks passed
@tenthirtyam tenthirtyam removed the needs-review Needs Review label Mar 5, 2024
@github-actions github-actions bot added the needs-review Needs Review label Mar 5, 2024
@tenthirtyam tenthirtyam deleted the bugfix/example_file_for_edge_cluster branch March 5, 2024 03:08
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 5, 2024

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 5, 2024
@tenthirtyam tenthirtyam removed the needs-review Needs Review label Jun 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tenthirtyam tenthirtyam tenthirtyam approved these changes

Assignees

@spacegospod spacegospod

Labels
documentation Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Example file has a non working key name in vcf_edge_cluster.tf
2 participants
@spacegospod @tenthirtyam