feat: add support for nsx edge clusters #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spacegospod
requested review from
raj-chelur,
tenthirtyam,
dimitarproynov and
vasilsatanasov
github-actions
bot
added
documentation
spacegospod
force-pushed
the
feature/edge-cluster
branch
from
25c45ed to
c21c6f0
Compare
spacegospod
force-pushed
the
feature/edge-cluster
branch
2 times, most recently
from
fb68903 to
1b93c9e
Compare
tenthirtyam
changed the title
tenthirtyam
force-pushed
the
feature/edge-cluster
branch
from
1b93c9e to
9b05098
Compare
tenthirtyam
reviewed
Jan 23, 2024
tenthirtyam
reviewed
Jan 23, 2024
tenthirtyam
reviewed
Jan 23, 2024
tenthirtyam
force-pushed
the
feature/edge-cluster
branch
3 times, most recently
from
799844e to
308895b
Compare
dimitarproynov
requested changes
Jan 24, 2024
spacegospod
force-pushed
the
feature/edge-cluster
branch
from
308895b to
ed2f748
Compare
spacegospod
force-pushed
the
feature/edge-cluster
branch
3 times, most recently
from
84d3967 to
1faa0e7
Compare
dimitarproynov
requested changes
Jan 29, 2024
spacegospod
force-pushed
the
feature/edge-cluster
branch
5 times, most recently
from
72a4c71 to
807d547
Compare
Adds a new resource for NSX Edge Clusters. The lifecycle of the resource is based on the public API and supports creation, expansion, and shrinkage. Formatted all .tf files with `terraform fmt -recursive`. Ref: #111 Signed-off-by: Stoyan Zhelyazkov <[email protected]> Signed-off-by: Stoyan Zhelyazkov <[email protected]> Signed-off-by: Stoyan Zhelyazkov <[email protected]>
spacegospod
force-pushed
the
feature/edge-cluster
branch
from
807d547 to
7b59488
Compare
dimitarproynov
approved these changes
Jan 30, 2024
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Pull Request
Creating a new resource for Edge Clusters. The lifecycle of the new resource is based on the public API and supports creation, expansion and shrinkage.
Edge Cluster deletion is not included in this iteration since it is not officially supported by the API. A workaround has been provided (see delete context for details)
Formatted all .tf files with
terraform fmt -recursive.Type of Pull Request
Please describe:
Related to Existing Issues
Closes #111
Test and Documentation Coverage
Added a new acceptance test suite for the new resource
accLog.txt
For bug fixes or features:
Breaking Changes?