-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue 944 - allow org users to read shared catalogs #949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes fix the problem of a catalog that was shared to the current org, but a tenant could not retrieve it for lack of privileges. It also fixes the case when multiple catalogs with the same name are available in the organization. The new functions search for catalogs without need of accessing the sharing organization. Also added a new 'is_local' property to all catalog resources and data sources. This property tells whether the catalog was created in the current org or not. Signed-off-by: Giuseppe Maxia <[email protected]>
Signed-off-by: Giuseppe Maxia <[email protected]>
Signed-off-by: Giuseppe Maxia <[email protected]>
Signed-off-by: Giuseppe Maxia <[email protected]>
Signed-off-by: Giuseppe Maxia <[email protected]>
Signed-off-by: Giuseppe Maxia <[email protected]>
Signed-off-by: Giuseppe Maxia <[email protected]>
Improve search as system administrator Signed-off-by: Giuseppe Maxia <[email protected]>
Signed-off-by: Giuseppe Maxia <[email protected]>
adambarreiro
approved these changes
Dec 2, 2022
Signed-off-by: Giuseppe Maxia <[email protected]>
Signed-off-by: Giuseppe Maxia <[email protected]>
Didainius
approved these changes
Dec 5, 2022
Signed-off-by: Giuseppe Maxia <[email protected]>
Signed-off-by: Giuseppe Maxia <[email protected]>
lvirbalas
reviewed
Dec 5, 2022
Signed-off-by: Giuseppe Maxia <[email protected]>
lvirbalas
reviewed
Dec 5, 2022
Signed-off-by: Giuseppe Maxia <[email protected]>
lvirbalas
approved these changes
Dec 5, 2022
Signed-off-by: Giuseppe Maxia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address issue #944
Fix title of catalog operations guide
Add functions to find a catalog without its Org
These changes fix the problem of a catalog that was shared
to the current org, but a tenant could not retrieve it
for lack of privileges.
It also fixes the case when multiple catalogs with the same
name are available in the organization.
The new functions search for catalogs without need of accessing
the sharing organization.
Also added a new 'is_local' property to all catalog resources and data sources.
This property tells whether the catalog was created in the current org
or not.
When there are multiple catalogs with the same name in one Org, and users attempt retrieving a data source, there are two possibilities:
org
field. The data source gets retrieved as if it were local.Side effect: There is still a problem, which existed before, but has been made official by an appropriate error message in this PR: when searching a data source by filter (not by name), the filter only works if the Org containing the catalog is reachable by the user. Thus, it won't work for a shared catalog.