Add vcd_ui_plugin resource and data source to programmatically manage UI Plugins

.changes/v3.10.0/1059-features.md

@@ -0,0 +1,2 @@
+* **New Resource:** `vcd_ui_plugin` to programmatically install and manage UI Plugins [GH-1059]
+* **New Data Source:** `vcd_ui_plugin` to fetch existing UI Plugins [GH-1059]

.changes/v3.10.0/1059-improvements.md

@@ -0,0 +1 @@
+* The guide to install Container Service Extension v4.0 now additionally installs the Kubernetes Container Clusters UI Plugin [GH-1059]

examples/container-service-extension-4.0/install/step1/3.9-cse-4.0-install-step1.tf → examples/container-service-extension-4.0/install/step1/3.10-cse-4.0-install-step1.tf

@@ -15,12 +15,12 @@
 #   You can check the comments on each resource/data source for more help and context.
 # ------------------------------------------------------------------------------------------------------------
 
-# VCD Provider configuration. It must be at least v3.9.0 and configured with a System administrator account.
+# VCD Provider configuration. It must be at least v3.10.0 and configured with a System administrator account.
 terraform {
   required_providers {
     vcd = {
       source  = "vmware/vcd"
-      version = ">= 3.9"
+      version = ">= 3.10"
     }
   }
 }

examples/container-service-extension-4.0/install/step2/3.9-cse-4.0-install-step2.tf → examples/container-service-extension-4.0/install/step2/3.10-cse-4.0-install-step2.tf

@@ -4,7 +4,7 @@
 # * Please read the guide present at https://registry.terraform.io/providers/vmware/vcd/latest/docs/guides/container_service_extension_4_0
 #   before applying this configuration.
 #
-# * Please apply "3.9-cse-4.0-install-step1.tf" first, located at
+# * Please apply "3.10-cse-4.0-install-step1.tf" first, located at
 #   https://github.com/vmware/terraform-provider-vcd/tree/main/examples/container-service-extension-4.0/install/step1
 #
 # * Please review this HCL configuration before applying, to change the settings to the ones that fit best with your organization.
@@ -15,13 +15,13 @@
 #   You can check the comments on each resource/data source for more help and context.
 # ------------------------------------------------------------------------------------------------------------
 
-# VCD Provider configuration. It must be at least v3.9.0 and configured with a System administrator account.
+# VCD Provider configuration. It must be at least v3.10.0 and configured with a System administrator account.
 # This is needed to build the minimum setup for CSE v4.0 to work, like Organizations, VDCs, Provider Gateways, etc.
 terraform {
   required_providers {
     vcd = {
       source  = "vmware/vcd"
-      version = ">= 3.9"
+      version = ">= 3.10"
     }
   }
 }
@@ -293,7 +293,7 @@ resource "vcd_catalog_vapp_template" "cse_ova" {
   ova_path    = format("%s/%s", var.cse_ova_folder, var.cse_ova_file)
 }
 
-# Fetch the RDE Type created in 3.9-cse-4.0-install-step1.tf. This is required to be able to create the following
+# Fetch the RDE Type created in 3.10-cse-4.0-install-step1.tf. This is required to be able to create the following
 # Rights Bundle.
 data "vcd_rde_type" "existing_capvcdcluster_type" {
   vendor  = "vmware"
@@ -675,7 +675,7 @@ resource "vcd_nsxt_firewall" "tenant_firewall" {
   }
 }
 
-# Fetch the RDE Type created in 3.9-cse-4.0-install-step1.tf, as we need to create the configuration instance.
+# Fetch the RDE Type created in 3.10-cse-4.0-install-step1.tf, as we need to create the configuration instance.
 data "vcd_rde_type" "existing_vcdkeconfig_type" {
   vendor  = "vmware"
   nss     = "VCDKEConfig"
@@ -769,6 +769,17 @@ resource "vcd_vapp_vm" "cse_server_vm" {
   ]
 }
 
-output "publish_ui_plugin" {
-  value = "When CSE Server '${vcd_vapp_vm.cse_server_vm.name}' is ready, please install the Kubernetes Container Clusters UI plug-in 4.0 for VCD that you can download from https://docs.vmware.com/en/VMware-Cloud-Director-Container-Service-Extension/index.html"
+data "vcd_org" "system_org" {
+  name = var.administrator_org
+}
+
+resource vcd_ui_plugin "k8s_container_clusters_ui_plugin" {
+  count = var.k8s_container_clusters_ui_plugin_path == "" ? 0 : 1
+  plugin_path = var.k8s_container_clusters_ui_plugin_path
+  enabled = true
+  tenant_ids = [
+    data.vcd_org.system_org.id,
+    vcd_org.solutions_organization.id,
+    vcd_org.tenant_organization.id,
+  ]
 }

examples/container-service-extension-4.0/install/step2/terraform.tfvars.example

@@ -109,3 +109,11 @@ github_personal_access_token = "ghp_xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx"
 # This user was created in Step 1. You need to provide a valid API token for it
 cse_admin_user      = "cse-admin"
 cse_admin_api_token = "xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx"
+
+# ------------------------------------------------
+# Other configuration
+# ------------------------------------------------
+# This path points to the .zip file that contains the bundled Kubernetes Container Clusters UI Plugin.
+# It is optional, if not informed it won't be installed.
+# Remember to remove older CSE UI plugins if present (for example 3.x plugins) after installing this one.
+k8s_container_clusters_ui_plugin_path = "/home/change-me/container-ui-plugin 4.0.zip"

examples/container-service-extension-4.0/install/step2/variables.tf

@@ -313,3 +313,12 @@ variable "syslog_port" {
   description = "VCDKEConfig: Port for system logs"
   default     = ""
 }
+
+# ------------------------------------------------
+# Other configuration
+# ------------------------------------------------
+variable "k8s_container_clusters_ui_plugin_path" {
+  type        = string
+  description = "Path to the Kubernetes Container Clusters UI Plugin zip file"
+  default     = ""
+}

go.mod

@@ -20,7 +20,7 @@ require (
 	github.com/hashicorp/errwrap v1.0.0 // indirect
 	github.com/hashicorp/go-checkpoint v0.5.0 // indirect
 	github.com/hashicorp/go-cleanhttp v0.5.2 // indirect
-	github.com/hashicorp/go-cty v1.4.1-0.20200414143053-d3edf31b6320 // indirect
+	github.com/hashicorp/go-cty v1.4.1-0.20200414143053-d3edf31b6320
 	github.com/hashicorp/go-hclog v1.4.0 // indirect
 	github.com/hashicorp/go-multierror v1.1.1 // indirect
 	github.com/hashicorp/go-plugin v1.4.8 // indirect
@@ -60,3 +60,5 @@ require (
 	google.golang.org/grpc v1.51.0 // indirect
 	google.golang.org/protobuf v1.28.1 // indirect
 )
+
+replace github.com/vmware/go-vcloud-director/v2 => github.com/adambarreiro/go-vcloud-director/v2 v2.17.0-alpha.1.0.20230526090050-e6e6ef3844ee

go.sum

@@ -11,6 +11,8 @@ github.com/ProtonMail/go-crypto v0.0.0-20210428141323-04723f9f07d7 h1:YoJbenK9C6
 github.com/ProtonMail/go-crypto v0.0.0-20210428141323-04723f9f07d7/go.mod h1:z4/9nQmJSSwwds7ejkxaJwO37dru3geImFUdJlaLzQo=
 github.com/acomagu/bufpipe v1.0.3 h1:fxAGrHZTgQ9w5QqVItgzwj235/uYZYgbXitB+dLupOk=
 github.com/acomagu/bufpipe v1.0.3/go.mod h1:mxdxdup/WdsKVreO5GpW4+M/1CE2sMG4jeGJ2sYmHc4=
+github.com/adambarreiro/go-vcloud-director/v2 v2.17.0-alpha.1.0.20230526090050-e6e6ef3844ee h1:ghaFIj7spkheFoIOFhnfNP5k/jyInidf7K9gf6v4c7g=
+github.com/adambarreiro/go-vcloud-director/v2 v2.17.0-alpha.1.0.20230526090050-e6e6ef3844ee/go.mod h1:QPxGFgrUcSyzy9IlpwDE4UNT3tsOy2047tJOPEJ4nlw=
 github.com/agext/levenshtein v1.2.2 h1:0S/Yg6LYmFJ5stwQeRp6EeOcCbj7xiqQSdNelsXvaqE=
 github.com/agext/levenshtein v1.2.2/go.mod h1:JEDfjyjHDjOF/1e4FlBE/PkbqA9OfWu2ki2W0IB5558=
 github.com/anmitsu/go-shlex v0.0.0-20161002113705-648efa622239/go.mod h1:2FmKhYUyUczH0OGQWaF5ceTx0UBShxjsH6f8oGKYe2c=
@@ -194,8 +196,6 @@ github.com/vmihailenco/msgpack/v4 v4.3.12 h1:07s4sz9IReOgdikxLTKNbBdqDMLsjPKXwvC
 github.com/vmihailenco/msgpack/v4 v4.3.12/go.mod h1:gborTTJjAo/GWTqqRjrLCn9pgNN+NXzzngzBKDPIqw4=
 github.com/vmihailenco/tagparser v0.1.1 h1:quXMXlA39OCbd2wAdTsGDlK9RkOk6Wuw+x37wVyIuWY=
 github.com/vmihailenco/tagparser v0.1.1/go.mod h1:OeAg3pn3UbLjkWt+rN9oFYB6u/cQgqMEUPoW2WPyhdI=
-github.com/vmware/go-vcloud-director/v2 v2.20.0 h1:vT1vmh6uxJPE5a4d2nSj8KmF3C0kb/1UF2hn6hp7vr0=
-github.com/vmware/go-vcloud-director/v2 v2.20.0/go.mod h1:QPxGFgrUcSyzy9IlpwDE4UNT3tsOy2047tJOPEJ4nlw=
 github.com/xanzy/ssh-agent v0.3.0 h1:wUMzuKtKilRgBAD1sUb8gOwwRr2FGoBVumcjoOACClI=
 github.com/xanzy/ssh-agent v0.3.0/go.mod h1:3s9xbODqPuuhK9JV1R321M/FlMZSBvE5aY6eAcqrDh0=
 github.com/yuin/goldmark v1.4.13/go.mod h1:6yULJ656Px+3vBD8DxQVa3kxgyrAnzto9xy5taEt/CY=

vcd/datasource_vcd_ui_plugin.go

@@ -0,0 +1,77 @@
+package vcd
+
+import (
+	"context"
+	"github.com/hashicorp/terraform-plugin-sdk/v2/diag"
+	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
+)
+
+func datasourceVcdUIPlugin() *schema.Resource {
+	return &schema.Resource{
+		ReadContext: datasourceVcdUIPluginRead,
+		Schema: map[string]*schema.Schema{
+			"vendor": {
+				Type:        schema.TypeString,
+				Required:    true,
+				Description: "The UI Plugin vendor name. Combination of `vendor`, `name` and `version` must be unique",
+			},
+			"name": {
+				Type:        schema.TypeString,
+				Required:    true,
+				Description: "The UI Plugin name. Combination of `vendor`, `name` and `version` must be unique",
+			},
+			"version": {
+				Type:        schema.TypeString,
+				Required:    true,
+				Description: "The version of the UI Plugin. Combination of `vendor`, `name` and `version` must be unique",
+			},
+			"license": {
+				Type:        schema.TypeString,
+				Computed:    true,
+				Description: "The license of the UI Plugin",
+			},
+			"link": {
+				Type:        schema.TypeString,
+				Computed:    true,
+				Description: "The website of the UI Plugin",
+			},
+			"description": {
+				Type:        schema.TypeString,
+				Computed:    true,
+				Description: "The description of the UI Plugin",
+			},
+			"provider_scoped": {
+				Type:        schema.TypeBool,
+				Computed:    true,
+				Description: "'true' if the UI Plugin scope is the service provider. 'false' if not",
+			},
+			"tenant_scoped": {
+				Type:        schema.TypeBool,
+				Computed:    true,
+				Description: "true if the UI Plugin scope is the tenants (organizations)",
+			},
+			"enabled": {
+				Type:        schema.TypeBool,
+				Computed:    true,
+				Description: "true if the UI Plugin is enabled. 'false' if not",
+			},
+			"status": {
+				Type:        schema.TypeString,
+				Computed:    true,
+				Description: "Status of the UI Plugin",
+			},
+			"tenant_ids": {
+				Type: schema.TypeSet,
+				Elem: &schema.Schema{
+					Type: schema.TypeString,
+				},
+				Computed:    true,
+				Description: "Set of Organization IDs where the UI Plugin is published to",
+			},
+		},
+	}
+}
+
+func datasourceVcdUIPluginRead(ctx context.Context, d *schema.ResourceData, meta interface{}) diag.Diagnostics {
+	return genericVcdUIPluginRead(ctx, d, meta, "datasource")
+}

vcd/provider.go

@@ -120,6 +120,7 @@ var globalDataSourceMap = map[string]*schema.Resource{
 	"vcd_nsxt_edgegateway_qos_profile":              datasourceVcdNsxtEdgeGatewayQosProfile(),        // 3.9
 	"vcd_nsxt_edgegateway_rate_limiting":            datasourceVcdNsxtEdgegatewayRateLimiting(),      // 3.9
 	"vcd_nsxt_network_dhcp_binding":                 datasourceVcdNsxtDhcpBinding(),                  // 3.9
+	"vcd_ui_plugin":                                 datasourceVcdUIPlugin(),                         // 3.10
 }
 
 var globalResourceMap = map[string]*schema.Resource{
@@ -204,6 +205,7 @@ var globalResourceMap = map[string]*schema.Resource{
 	"vcd_rde":                                       resourceVcdRde(),                              // 3.9
 	"vcd_nsxt_edgegateway_rate_limiting":            resourceVcdNsxtEdgegatewayRateLimiting(),      // 3.9
 	"vcd_nsxt_network_dhcp_binding":                 resourceVcdNsxtDhcpBinding(),                  // 3.9
+	"vcd_ui_plugin":                                 resourceVcdUIPlugin(),                         // 3.10
 }
 
 // Provider returns a terraform.ResourceProvider.

vcd/remove_leftovers_test.go

@@ -301,6 +301,23 @@ func removeLeftovers(govcdClient *govcd.VCDClient, verbose bool) error {
 			}
 		}
 	}
+	// --------------------------------------------------------------
+	// Plugins
+	// --------------------------------------------------------------
+	uiPlugins, err := govcdClient.GetAllUIPlugins()
+	if err != nil {
+		return fmt.Errorf("error retrieving UI Plugins: %s", err)
+	}
+	for _, uiPlugin := range uiPlugins {
+		toBeDeleted := shouldDeleteEntity(alsoDelete, doNotDelete, uiPlugin.UIPluginMetadata.PluginName, "vcd_ui_plugin", 1, verbose)
+		if toBeDeleted {
+			err = deleteUIPlugin(uiPlugin)
+			if err != nil {
+				return fmt.Errorf("error deleting UI Plugin '%s': %s", uiPlugin.UIPluginMetadata.ID, err)
+			}
+		}
+	}
+
 	return nil
 }
 
@@ -627,3 +644,12 @@ func deleteRdeType(rdeType *govcd.DefinedEntityType) error {
 	}
 	return nil
 }
+
+func deleteUIPlugin(uiPlugin *govcd.UIPlugin) error {
+	fmt.Printf("\t\t REMOVING UI PLUGIN %s\n", uiPlugin.UIPluginMetadata.ID)
+	err := uiPlugin.Delete()
+	if err != nil {
+		return fmt.Errorf("error deleting UI Plugin '%s': %s", uiPlugin.UIPluginMetadata.ID, err)
+	}
+	return nil
+}