added support for returning array of BaseCnsVolumeOperationResult for QueryVolumeInfo API

[divyenpatel]

Fixes #2010, kubernetes-sigs/vsphere-csi-driver#249

Fixed issue reported by @SandeepPissay at - kubernetes-sigs/vsphere-csi-driver#235 (comment)

QueryVolumeInfo can take multiple Volumes IDs as input and should returns an array of BaseCnsVolumeOperationResult.

In this PR, I am adding function GetTaskResultArray to help retrieve array of BaseCnsVolumeOperationResult for all specified volumes in the QueryVolumeInfo request.

Testing Done.

Request

  client_test.go:224: Calling QueryVolumeInfo using: []types.CnsVolumeId{
            {
                Id: "759f3fa8-f692-4a8e-b65c-3fcd56d0f947",
            },
            {
                Id: "c2c2d2bb-f864-4e4f-9bde-39ca6b1302b6",
            },
            {
                Id: "6885ca7d-09a3-40f5-9706-475cbd479934",
            },
        }

Response

    client_test.go:244: queryVolumeInfoTaskResults: []types.BaseCnsVolumeOperationResult{
            &types.CnsQueryVolumeInfoResult{
                CnsVolumeOperationResult: types.CnsVolumeOperationResult{},
                VolumeInfo:               &types.CnsBlockVolumeInfo{
                    CnsVolumeInfo:  types.CnsVolumeInfo{},
                    VStorageObject: types.VStorageObject{
                        Config: types.VStorageObjectConfigInfo{
                            BaseConfigInfo: types.BaseConfigInfo{
                                Id: types.ID{
                                    Id: "759f3fa8-f692-4a8e-b65c-3fcd56d0f947",
                                },
                                Name:                        "pvc-901e87eb-c2bd-11e9-806f-005056a0c9a0",
                                CreateTime:                  time.Now(),
                                KeepAfterDeleteVm:           types.NewBool(true),
                                RelocationDisabled:          types.NewBool(false),
                                NativeSnapshotSupported:     types.NewBool(false),
                                ChangedBlockTrackingEnabled: types.NewBool(false),
                                Backing:                     &types.BaseConfigInfoDiskFileBackingInfo{
                                    BaseConfigInfoFileBackingInfo: types.BaseConfigInfoFileBackingInfo{
                                        BaseConfigInfoBackingInfo: types.BaseConfigInfoBackingInfo{
                                            Datastore: types.ManagedObjectReference{Type:"Datastore", Value:"datastore-68"},
                                        },
                                        FilePath:        "[vsanDatastore] 879cd65e-6165-91a3-d047-02000359156d/cdde909c19b64305826a0e0e96fbdc06.vmdk",
                                        BackingObjectId: "4ac6fb5e-f617-2568-199f-020003bb3e3c",
                                        Parent:          nil,
                                        DeltaSizeInMB:   0,
                                        KeyId:           (*types.CryptoKeyId)(nil),
                                    },
                                    ProvisioningType: "thin",
                                },
                                Iofilter: nil,
                            },
                            CapacityInMB:    5120,
                            ConsumptionType: []string{"disk"},
                            ConsumerId:      nil,
                        },
                    },
                },
            },
            &types.CnsQueryVolumeInfoResult{
                CnsVolumeOperationResult: types.CnsVolumeOperationResult{},
                VolumeInfo:               &types.CnsBlockVolumeInfo{
                    CnsVolumeInfo:  types.CnsVolumeInfo{},
                    VStorageObject: types.VStorageObject{
                        Config: types.VStorageObjectConfigInfo{
                            BaseConfigInfo: types.BaseConfigInfo{
                                Id: types.ID{
                                    Id: "c2c2d2bb-f864-4e4f-9bde-39ca6b1302b6",
                                },
                                Name:                        "pvc-901e87eb-c2bd-11e9-806f-005056a0c9a0",
                                CreateTime:                  time.Now(),
                                KeepAfterDeleteVm:           types.NewBool(true),
                                RelocationDisabled:          types.NewBool(false),
                                NativeSnapshotSupported:     types.NewBool(false),
                                ChangedBlockTrackingEnabled: types.NewBool(false),
                                Backing:                     &types.BaseConfigInfoDiskFileBackingInfo{
                                    BaseConfigInfoFileBackingInfo: types.BaseConfigInfoFileBackingInfo{
                                        BaseConfigInfoBackingInfo: types.BaseConfigInfoBackingInfo{
                                            Datastore: types.ManagedObjectReference{Type:"Datastore", Value:"datastore-68"},
                                        },
                                        FilePath:        "[vsanDatastore] 879cd65e-6165-91a3-d047-02000359156d/a1feda38c5ca4f9d9e63721b8fbaeb83.vmdk",
                                        BackingObjectId: "acbcfb5e-1d86-55b1-932c-020003e15f4d",
                                        Parent:          nil,
                                        DeltaSizeInMB:   0,
                                        KeyId:           (*types.CryptoKeyId)(nil),
                                    },
                                    ProvisioningType: "thin",
                                },
                                Iofilter: nil,
                            },
                            CapacityInMB:    10240,
                            ConsumptionType: []string{"disk"},
                            ConsumerId:      nil,
                        },
                    },
                },
            },
            &types.CnsQueryVolumeInfoResult{
                CnsVolumeOperationResult: types.CnsVolumeOperationResult{},
                VolumeInfo:               &types.CnsBlockVolumeInfo{
                    CnsVolumeInfo:  types.CnsVolumeInfo{},
                    VStorageObject: types.VStorageObject{
                        Config: types.VStorageObjectConfigInfo{
                            BaseConfigInfo: types.BaseConfigInfo{
                                Id: types.ID{
                                    Id: "6885ca7d-09a3-40f5-9706-475cbd479934",
                                },
                                Name:                        "pvc-60209158-c603-4534-85df-6d193490b5fa",
                                CreateTime:                  time.Now(),
                                KeepAfterDeleteVm:           types.NewBool(true),
                                RelocationDisabled:          types.NewBool(false),
                                NativeSnapshotSupported:     types.NewBool(false),
                                ChangedBlockTrackingEnabled: types.NewBool(false),
                                Backing:                     &types.BaseConfigInfoDiskFileBackingInfo{
                                    BaseConfigInfoFileBackingInfo: types.BaseConfigInfoFileBackingInfo{
                                        BaseConfigInfoBackingInfo: types.BaseConfigInfoBackingInfo{
                                            Datastore: types.ManagedObjectReference{Type:"Datastore", Value:"datastore-68"},
                                        },
                                        FilePath:        "[vsanDatastore] 879cd65e-6165-91a3-d047-02000359156d/ac0b516b5eb54abe890dae868ad36e4a.vmdk",
                                        BackingObjectId: "66a8e75e-c096-baad-99b6-020003df5b47",
                                        Parent:          nil,
                                        DeltaSizeInMB:   0,
                                        KeyId:           (*types.CryptoKeyId)(nil),
                                    },
                                    ProvisioningType: "thin",
                                },
                                Iofilter: nil,
                            },
                            CapacityInMB:    5120,
                            ConsumptionType: []string{"disk"},
                            ConsumerId:      nil,
                        },
                    },
                },
            },
        }

[divyenpatel]

@SandeepPissay @chethanv28 please take a look

[SandeepPissay]

/lgtm

[SandeepPissay]

/approve

[chethanv28]

Minor comments, otherwise lgtm-ish

[divyenpatel]

@dougm Can you help merge this PR?

[dougm]

Thanks @divyenpatel