-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SSL validation and connection test to LDAP configuration methods #746
Open
adambarreiro
wants to merge
15
commits into
vmware:main
Choose a base branch
from
adambarreiro:fix-ldap
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
adambarreiro
commented
Jan 31, 2025
} | ||
|
||
// If SSL is configured and retrieved settings are empty, or the hostname changed, we need to trust the certificate | ||
needsCheckCert := settings.IsSsl && (existing.HostName == "" || existing.HostName != settings.HostName) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I saw, if you change the host in UI, it doesn't re-trigger the certificate trusting popup. I think it should? So not sure if this should be so "smart" or simplify, but not re-trusting cert for changed host would make LDAP useless again.
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While PR #732 introduced basic support for LDAP in VMware Cloud Foundation Automation, the implemented methods had a few issues:
This PR enhances all implemented methods:
trustCertificate
flag istrue
, the methods now automatically trust the certificate if needed. Otherwise (trustCertificate=false
), the methods will fail.Additionally, instead of using dummy vCenter as LDAP server, the testing configuration allows to provide a customised LDAP server:
Last, it also adds support of Trusted Certificates for Tenants (
TmOrg
), which is required for configuring LDAP with SSL on tenants.