Miscellaneous fixes in methods and tests #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 18, 2024 16:58
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
added 2 commits
June 18, 2024 17:12
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
adambarreiro
requested review from
lvirbalas,
Didainius and
dataclouder
as code owners
Didainius
approved these changes
Jun 19, 2024
dataclouder
approved these changes
Jun 19, 2024
lvirbalas
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contents
Bugfixes
OpenAPIEdgeGatewayEdgeClustertype. TheOpenApiReferencewas not a pointer, hence the marshaller automatically created an empty struct with empty""values, that when sent to the VCD 10.6+ backend, caused errors. Now,OpenApiReferenceis a pointer. The testTest_NsxtEdgeCreatehas been updated to reproduce the issue. Running it should pass if the fix is applied.