Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NSX-T Edge Gateway DNS Configuration management #627

Merged
merged 18 commits into from
Nov 23, 2023

Conversation

adezxc
Copy link

@adezxc adezxc commented Nov 8, 2023

This PR implements management of the DNS forwarder service in an NSX-T Edge Gateway.

  • Added new NsxtEdgeGateway methods GetDnsConfig and UpdateDnsConfig.
  • Added new types types.NsxtEdgeGatewayDns, types.NsxtDnsForwarderZoneConfig.
  • Added methods for NsxtEdgeGatewayDns: Refresh, Update, Delete.

There is also a new field implemented in 38.0: SnatRuleExternalIpAddress, which is automatically set by VCD if an Edge Gateway isn't backed by IP spaces. It can be manually set to an allocated IP Spaces IP if the Edge Gateway is backed by IP spaces.

Adam Jasinski added 9 commits October 12, 2023 18:38
Signed-off-by: Adam Jasinski <[email protected]>
Signed-off-by: Adam Jasinski <[email protected]>
Signed-off-by: Adam Jasinski <[email protected]>
Signed-off-by: Adam Jasinski <[email protected]>
Signed-off-by: Adam Jasinski <[email protected]>
Adam Jasinski added 2 commits November 13, 2023 11:22
Signed-off-by: Adam Jasinski <[email protected]>
Signed-off-by: Adam Jasinski <[email protected]>
@adezxc adezxc marked this pull request as ready for review November 13, 2023 10:03
Signed-off-by: Adam Jasinski <[email protected]>
Copy link
Collaborator

@adambarreiro adambarreiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test passed for me in 10.5.1

Signed-off-by: Adam Jasinski <[email protected]>
Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Small thought about changelog inline.

Adam Jasinski added 4 commits November 16, 2023 10:27
Signed-off-by: Adam Jasinski <[email protected]>
Signed-off-by: Adam Jasinski <[email protected]>
Signed-off-by: Adam Jasinski <[email protected]>
Signed-off-by: Adam Jasinski <[email protected]>
Signed-off-by: Adam Jasinski <[email protected]>
@adezxc adezxc merged commit 6fc491f into vmware:main Nov 23, 2023
@adezxc adezxc deleted the edgegateway_dns branch November 23, 2023 12:34
@adezxc adezxc restored the edgegateway_dns branch November 23, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants