Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add explicit removal of many resources from tests #605

Merged
merged 6 commits into from
Aug 17, 2023
Merged

Add explicit removal of many resources from tests #605

merged 6 commits into from
Aug 17, 2023

Conversation

dataclouder
Copy link
Contributor

@dataclouder dataclouder commented Aug 4, 2023 •
edited
Loading

Several resources were left undeleted, waiting for the cleanup function to remove them, increasing the risk of interfering with other tests.
This PR removes the resources most likely to affect other tests:

  • organizations
  • VDCs
  • group VDCs
  • vApps
  • networks

Testing:

go test -tags functional -check.vv  -timeout 0 -check.f 'TestCreateOrgVdcNetworkDhcp|TestVCD.TestQueryOrgVdcList|Test_CreateOrgVdcNetworkDirect|Test_CreateOrgVdcNetworkIso|Test_CreateUpdateOrgVdcNetworkDirect|Test_CreateUpdateOrgVdcNetworkIso|Test_CreateVdcGroup|Test_GlobalRoles|Test_NsxtIpSet|Test_NsxtOrgVdcNetworkImportedNsxtLogicalSwitch|Test_NsxtOrgVdcNetworkIsolated|Test_NsxtOrgVdcNetworkRouted|Test_NsxtSecurityGroupGetAssociatedVms|Test_NsxtVdcGroup|Test_NsxtVdcGroupOrgNetworks|Test_NsxtVdcGroupWithOrgAdmin|Test_QueryOrgVdcNetworkByNameWithSpace|Test_QueryProviderVdcEntities|Test_RightsBundle|Test_SearchOrgVdc|Test_UpdateNetworkStaticRoutes|Test_UpdateVdc|Test_UpdateVdcFlex|Test_VMGetDhcpAddress|Test_VdcUpdateStorageProfile'

Add changelog item
3c3bd12 
Signed-off-by: Giuseppe Maxia <[email protected]>
@dataclouder dataclouder marked this pull request as ready for review August 4, 2023 09:10
@dataclouder dataclouder self-assigned this Aug 4, 2023
adambarreiro
adambarreiro approved these changes Aug 4, 2023
View reviewed changes
Copy link
Collaborator

@adambarreiro adambarreiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for these improvements.

lvirbalas
lvirbalas approved these changes Aug 17, 2023
View reviewed changes
Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dataclouder dataclouder merged commit 8249086 into vmware:main Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adambarreiro adambarreiro adambarreiro approved these changes

@lvirbalas lvirbalas lvirbalas approved these changes

@Didainius Didainius Didainius approved these changes

@adezxc adezxc adezxc approved these changes

Assignees

@dataclouder dataclouder

Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dataclouder @adambarreiro @lvirbalas @Didainius @adezxc @vmwclabot