Fix vApp network related tests #595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test_AddAndRemoveOrgVappNetworkWithMinimumValues, Test_AddAndRemoveOrgVappNetwork, and Test_UpdateOrgVappNetwork were faiiling on VCD 10.5.0 for two reasons: * The call to vapp.AddOrgNetwork was adding the same network that was already in the vApp. In 10.5.0, a stricter check forbade such false addition * In two of the tests, the vApp reftesh was performed on the default test vApp (The one created by 'TestSetUpSuite') instead of the vApp being created in the test This fix adds a second network to the vApp and amends the Refresh call. Signed-off-by: Giuseppe Maxia <[email protected]>
dataclouder
requested review from
lvirbalas,
Didainius,
adambarreiro and
adezxc
as code owners
Signed-off-by: Giuseppe Maxia <[email protected]>
Didainius
approved these changes
Jul 26, 2023
lvirbalas
approved these changes
Jul 26, 2023
adezxc
approved these changes
Jul 31, 2023
adambarreiro
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test_AddAndRemoveOrgVappNetworkWithMinimumValues,Test_AddAndRemoveOrgVappNetwork, andTest_UpdateOrgVappNetworkwere failing on VCD 10.5.0 for two reasons:vapp.AddOrgNetworkwas adding the same network that was already in the vApp: In 10.5.0, a stricter check forbade such false addition (*)TestSetUpSuite) instead of the vApp being created in the testThis fix adds a second network to the vApp and amends the Refresh call.
(*) Example: error updating vApp Network: API Error: 400: Cannot have two networks with the same name net-scheduled-r within this vApp
Testing