Fix UI Plugin failing tests #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
adambarreiro
requested review from
lvirbalas,
Didainius,
dataclouder and
adezxc
as code owners
Signed-off-by: abarreiro <[email protected]>
Didainius
approved these changes
Jun 26, 2023
lvirbalas
approved these changes
Jun 26, 2023
adezxc
approved these changes
Jun 26, 2023
dataclouder
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR complements #575 as it fixes a failing unit test.
The reason of the failure is that the unit test was referencing a variable defined in a regular test, which is not visible when using the
unittag.I have refactored the code so the variable doesn't need to be global anymore.
I've also added the
unitstep to the GitHub Action, to run the unit tests in PRs withmake testunit, so we minimize the chances of this happening again.