Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IP Space integration #579

Merged
merged 26 commits into from
Jul 13, 2023
Merged

IP Space integration #579

merged 26 commits into from
Jul 13, 2023

Conversation

Didainius
Copy link
Collaborator

@Didainius Didainius commented Jun 1, 2023 •
edited
Loading

This PR finalizes IP Space integration to the SDK which was started in #578.

It now adds support for the integration layer which consists of:

  • Additional field for external network to support IP spaces
  • IP Space Uplink management for external networks with new type IpSpaceUplink
  • IP Space IP and Prefix Allocation using new type IpSpaceIpAllocation
  • IP Space Org allocation to define custom quotas using new type IpSpaceOrgAssignment

Additionally, a type TaskResult is attached to Task as IP Allocation Requests return values in that field.

Tested on 10.3.0 (validated test skips), 10.4.1, 10.4.2

Didainius added 7 commits May 30, 2023 09:00
@Didainius
IP Spaces
0c36227 
Signed-off-by: Dainius Serplis <[email protected]>
@Didainius
Merge branch 'main' into ipspaces1
97893af
@Didainius
Self review 1
db1abdc 
Signed-off-by: Dainius Serplis <[email protected]>
@Didainius
Self review 2
5ce0566 
Signed-off-by: Dainius Serplis <[email protected]>
@Didainius
Self revew, missing function
ea77ee6 
Signed-off-by: Dainius Serplis <[email protected]>
@Didainius
Add IP Space support for External network
3ecd75d 
Signed-off-by: Dainius Serplis <[email protected]>
@Didainius
Add IP Space Uplink support
97eaa39 
Signed-off-by: Dainius Serplis <[email protected]>
Didainius added 12 commits June 2, 2023 13:46
@Didainius
Add IP Space support for NSX-T Edge Gateway
c777651 
Signed-off-by: Dainius Serplis <[email protected]>
@Didainius
Add IP Allocation support
95ba2ec 
Signed-off-by: Dainius Serplis <[email protected]>
@Didainius
Add more tests
da82b71 
Signed-off-by: Dainius Serplis <[email protected]>
@Didainius
Improvements
f41e113 
Signed-off-by: Dainius Serplis <[email protected]>
@Didainius
Merge main
f23fe91 
Signed-off-by: Dainius Serplis <[email protected]>
@Didainius
Add IP Space Org Assignment support
b2b9bba 
Signed-off-by: Dainius Serplis <[email protected]>
@Didainius
Self review and tests
fd37cb6 
Signed-off-by: Dainius Serplis <[email protected]>
@Didainius
Fix Changelog, make tagverify
dfbb2ee 
Signed-off-by: Dainius Serplis <[email protected]>
@Didainius
Add tenant context to requests
2088f2e 
Signed-off-by: Dainius Serplis <[email protected]>
@Didainius
Add missing test cleanup
4697cd6 
Signed-off-by: Dainius Serplis <[email protected]>
@Didainius
Add WaitForRunningTasksByName
d8057d3 
Signed-off-by: Dainius Serplis <[email protected]>
@Didainius
Self review
669835f 
Signed-off-by: Dainius Serplis <[email protected]>
@Didainius Didainius marked this pull request as ready for review June 27, 2023 03:39
lvirbalas
lvirbalas approved these changes Jun 27, 2023
View reviewed changes
Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, only few nit picks on comments "Update updates" and "Delete deletes".

@Didainius
Address comments
1cfad09 
Signed-off-by: Dainius Serplis <[email protected]>
adezxc
adezxc approved these changes Jul 3, 2023
View reviewed changes
Copy link

@adezxc adezxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Terrific work, approved. Only some questions

@Didainius
Address comment
093610e 
Signed-off-by: Dainius Serplis <[email protected]>
dataclouder
dataclouder reviewed Jul 5, 2023
View reviewed changes
adambarreiro
adambarreiro approved these changes Jul 12, 2023
View reviewed changes
Copy link
Collaborator

@adambarreiro adambarreiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR, just some really minor things

Didainius added 2 commits July 12, 2023 14:16
@Didainius
Remove incorrect comments
75184d8 
Adjust incorrect comments

Signed-off-by: Dainius Serplis <[email protected]>
@Didainius
Merge main
97848ce 
Signed-off-by: Dainius Serplis <[email protected]>
@Didainius Didainius merged commit 3b9ce5d into vmware:main Jul 13, 2023
@Didainius Didainius deleted the ipspaces22 branch July 13, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lvirbalas lvirbalas lvirbalas approved these changes

@adambarreiro adambarreiro adambarreiro approved these changes

@dataclouder dataclouder dataclouder approved these changes

@adezxc adezxc adezxc approved these changes

Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Didainius @adambarreiro @lvirbalas @dataclouder @adezxc @vmwclabot