Add ipv6 support for vApp network configuration #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 17, 2023 14:29
Signed-off-by: Adam Jasinski <[email protected]>
Signed-off-by: Adam Jasinski <[email protected]>
Signed-off-by: Adam Jasinski <[email protected]>
added 5 commits
February 20, 2023 15:56
Signed-off-by: Adam Jasinski <[email protected]>
Signed-off-by: Adam Jasinski <[email protected]>
Signed-off-by: Adam Jasinski <[email protected]>
Signed-off-by: Adam Jasinski <[email protected]>
Signed-off-by: Adam Jasinski <[email protected]>
adezxc
requested review from
lvirbalas,
Didainius,
adambarreiro and
dataclouder
as code owners
Didainius
reviewed
Feb 27, 2023
added 2 commits
February 27, 2023 15:51
Signed-off-by: Adam Jasinski <[email protected]>
Signed-off-by: Adam Jasinski <[email protected]>
Signed-off-by: Adam Jasinski <[email protected]>
lvirbalas
approved these changes
Mar 1, 2023
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: Adam Jasinski <[email protected]>
Didainius
reviewed
Mar 3, 2023
There was a problem hiding this comment.
I am pretty much good to approve, but a few notes here:
- changelog should have a bugfix entry about issue Nil point dereference in govcd.(*VApp).UpdateNetworkAsync #554
- your description of this PR has "closes vcd_vapp_org_network does not work properly with IPv6 networks in NSX-T terraform-provider-vcd#999", but it this still needs to be validated that
vcd_vapp_networkandvcd_vapp_org_networkboth work afterwards. (IMO better to close it with Terraform PR if we are sure it fixes it)
Signed-off-by: Adam Jasinski <[email protected]>
Sounds good, updated. |
Didainius
approved these changes
Mar 7, 2023
adambarreiro
approved these changes
Mar 10, 2023
dataclouder
approved these changes
Mar 10, 2023
Signed-off-by: Adam Jasinski <[email protected]>
lvirbalas
approved these changes
Mar 10, 2023
added 2 commits
March 10, 2023 10:49
Signed-off-by: Adam Jasinski <[email protected]>
Signed-off-by: Adam Jasinski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #554.
This PR adds support to creating vApp networks using ipv6, as before it would not work because
VAppNetworkConfigurationdidn't haveSubnetPrefixLengthfield which is needed for ipv6 handling. https://developer.vmware.com/apis/1507/vmware-cloud-director/doc/doc//types/IpScopeType.htmlPrefixLengthtoIPScopeandVappNetworkSettingsstructsTest_AddAndRemoveIsolatedVappNetworkIpv6which tests creation and removal of ipv6 vApp networksWorth noting, that the VCD API returns both
SubnetPrefixLengthandNetmaskon creation of ipv4 networks, but onlySubnetPrefixLengthon creation of ipv6 networks.Also fixes a bug in
UpdateNetworkAsync, that happened while trying to change fields of un-initializednetworkToUpdate.Configuration.Featuresfield