Fix catalog access #537
Merged
Fix catalog access #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dataclouder
commented
Jan 2, 2023
•
dataclouder
commented
- Remove URL checks from subscribed catalog creation Issue #967
- Add client methods to retrieve catalogs and admin catalogs (Issue #960)
- Add method to retrieve vApp template record (Issue #960)
- Add test for catalog retrieval with client methods
- Add test for catalog URL errors
added 5 commits
January 2, 2023 11:01
Signed-off-by: Giuseppe Maxia <[email protected]>
These methods do not require a full Organization object * GetAdminCatalogByHref * GetAdminCatalogById * GetAdminCatalogByName Signed-off-by: Giuseppe Maxia <[email protected]>
These methods do not require a full Organization object * GetCatalogByHref * GetCatalogById * GetCatalogByName Signed-off-by: Giuseppe Maxia <[email protected]>
Signed-off-by: Giuseppe Maxia <[email protected]>
Given a vApp template object, this method retrieves the corresponding query record Signed-off-by: Giuseppe Maxia <[email protected]>
Signed-off-by: Giuseppe Maxia <[email protected]>
dataclouder
requested review from
lvirbalas,
Didainius and
adambarreiro
as code owners
lvirbalas
reviewed
Jan 3, 2023
added 2 commits
January 4, 2023 14:20
Signed-off-by: Giuseppe Maxia <[email protected]>
Signed-off-by: Giuseppe Maxia <[email protected]>
Didainius
approved these changes
Jan 4, 2023
added 2 commits
January 4, 2023 16:00
Signed-off-by: Giuseppe Maxia <[email protected]>
Signed-off-by: Giuseppe Maxia <[email protected]>
lvirbalas
approved these changes
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.