Add VM.GetEnvironment() to retrieve OVF Environment

[odraghi]

Signed-off-by: Olivier DRAGHI [email protected]

Description

I need a way for a service running inside a VM to query cloud director as an OrgAdmin and find itself.
I think about checking the VM moref that is available with vmtools :
vmtoolsd --cmd "info-get guestinfo.ovfenv" | grep "ve:vCenterId" | cut -d'"' -f2

Unfortunately getting ovfenv ( Environment ) was not implemeted in govdc.

Related issue: (#526)

[dataclouder]

Thanks for this contribution.
Please, expand the description of this PR with the following:

1. What is the problem that you are trying to solve and the current code doesn't solve? In other words, define what is the purpose of this proposal.
2. Add at least one test that proves this change is doing what it is supposed to do. If you are unable to write such test (the gocheck environment requires some learning) please suggest what such test should do to prove that the change you propose is effective.

[adambarreiro]

Thanks for the contribution!
The new test passed for me in 10.4.1 and 10.3.0.
Just a couple of comments/suggestions/changes:

[lvirbalas]

(Tidying error messages).

[adambarreiro]

Thanks for the contribution!

[Didainius]

@odraghi ,
Thanks for all fixes. I am testing the SDK itself as well as will run our Terraform provider for VCD tests because the OVF properties belong to VM struct and it can have side effects

[odraghi]

@Didainius you're welcome, let me know if you need me to change something

[Didainius]

I have tried to run tests in such combination:

• go-vcloud-director was on 10.4.0 (whole suite passed) and 10.3.0 (some tests failed, but they don't look related)
• Terraform provider tests ran in 10.4.1 (based on this PR Testing PR: include govcd branch with govcd PR 528 terraform-provider-vcd#1016). A few tests failed, but not related to anything about OVF customization

[lvirbalas]

Thank you for contributing!

[Didainius]

Thanks @odraghi , this is in main now