-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to the Runtime Defined Entities (RDE) framework with Defined Interfaces (1/3) #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: abarreiro <[email protected]>
f374674
to
a9dd4c8
Compare
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
adambarreiro
commented
Jan 25, 2023
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
lvirbalas
reviewed
Jan 30, 2023
Signed-off-by: abarreiro <[email protected]>
lvirbalas
approved these changes
Jan 30, 2023
Didainius
reviewed
Jan 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few tiny ones. And just a check on API elevation makes any sense. I am good in general. Will approve both after checking out in Terraform PR
adambarreiro
commented
Jan 31, 2023
Signed-off-by: abarreiro <[email protected]>
Didainius
approved these changes
Jan 31, 2023
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
dataclouder
approved these changes
Feb 21, 2023
adezxc
approved these changes
Feb 22, 2023
Signed-off-by: abarreiro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR implements the foundations to onboard the RDE framework to the Terraform VCD Provider, by adding CRUD capabilities of Defined Interfaces.
Detailed description
This PR adds the following features:
VCDClient
:CreateDefinedInterface
to create a Defined Interface.GetAllDefinedInterfaces
to get all Defined Interfaces, supports parameters like filtering.GetDefinedInterface
gets a Defined Interface with its vendor+nss+version combination which is unique.GetDefinedInterfaceById
gets a Defined Interface with its URN, which is a combination of its vendor+nss+version underneath.DefinedInterface
type:Update
updates a Defined Interface with the given input. At the moment, only the name can be updated. If other parameters are set, they are simply ignored.Update
deletes a Defined Interface. The interface can't be deleted if it's referenced by some RDE type.Tests
The test in
defined_interface_test.go
checks the behaviour for both a System administrator and a tenant user.While System admins have access to all CRUD methods, tenant users can only read Defined Interfaces. This characteristic is tested.
Found quirks
amendDefinedInterfaceError
to amend a bug in VCD ≤ v10.3.0 that causes GET calls to return a 400 instead of a 403 when the Defined Entity does not exist. This bug seems fixed in versions higher than 10.3.0. For example, in VCD 10.3.1 I cannot reproduce it even if the request is done with v36.0.