Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add distributed firewall for NSX-V VDC #521

Merged
merged 36 commits into from
Mar 14, 2023

Conversation

dataclouder
Copy link
Contributor

@dataclouder dataclouder commented Nov 20, 2022

Functionalities added:

  • Check whether the Distributed Firewall service is enabled;
  • Enable Distributed Firewall service;
  • Remove Distributed Firewall service
  • Retrieve firewall rules
  • Retrieve firewall services and service groups
  • Add and update firewall rules
  • Test for the above

Note 1: as per product specification, this PR only deals with layer 3 firewall rules.

Note 2: Adding and updating rules is the same operation:

  • Both are added using a single PUT operation
  • Every PUT rewrites the whole rule set
  • Rule IDs are not considered when updating. The new rules, as indicated by the user, replace the old ones.
  • The ID of the rules section (a section is either a "level2" or "level3" collection of rules) stays unchanged, unless the firewall is created again.

Giuseppe Maxia added 6 commits November 20, 2022 22:17
@dataclouder dataclouder self-assigned this Nov 28, 2022
Giuseppe Maxia added 21 commits November 30, 2022 08:44
Signed-off-by: Giuseppe Maxia <[email protected]>
Signed-off-by: Giuseppe Maxia <[email protected]>
Each port field can hold either a single number or a range

Signed-off-by: Giuseppe Maxia <[email protected]>
Signed-off-by: Giuseppe Maxia <[email protected]>
Signed-off-by: Giuseppe Maxia <[email protected]>
Signed-off-by: Giuseppe Maxia <[email protected]>
Signed-off-by: Giuseppe Maxia <[email protected]>
Signed-off-by: Giuseppe Maxia <[email protected]>
Signed-off-by: Giuseppe Maxia <[email protected]>
Signed-off-by: Giuseppe Maxia <[email protected]>
Signed-off-by: Giuseppe Maxia <[email protected]>
Signed-off-by: Giuseppe Maxia <[email protected]>
@dataclouder dataclouder marked this pull request as ready for review March 5, 2023 17:36
@adambarreiro adambarreiro requested a review from adezxc March 6, 2023 08:38
@dataclouder dataclouder marked this pull request as draft March 6, 2023 12:38
@dataclouder dataclouder marked this pull request as ready for review March 6, 2023 14:09
Giuseppe Maxia added 2 commits March 7, 2023 19:42
Signed-off-by: Giuseppe Maxia <[email protected]>
Signed-off-by: Giuseppe Maxia <[email protected]>
Copy link
Collaborator

@Didainius Didainius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First scan

Giuseppe Maxia added 3 commits March 8, 2023 11:25
Copy link
Collaborator

@adambarreiro adambarreiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Giuseppe Maxia added 2 commits March 10, 2023 12:53
@dataclouder dataclouder merged commit aea05c4 into vmware:main Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants