Add support for VDC Network Profile configuration #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Didainius
force-pushed
the
255-edge-cluster-support
branch
from
fef84c0 to
65ef692
Compare
Signed-off-by: Dainius Serplis <[email protected]>
Didainius
requested review from
lvirbalas,
adambarreiro and
dataclouder
as code owners
Signed-off-by: Dainius Serplis <[email protected]>
lvirbalas
approved these changes
Nov 4, 2022
dataclouder
approved these changes
Nov 14, 2022
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for VCD Network Profile configuration. It is a prerequisite of vmware/terraform-provider-vcd#921. VDC Network Profile configuration is required so that one can assign NSX-T Edge Cluster to VDC. This, in turn, gives the chance to configure DHCP service for NSX-T Isolated Org VDC networks.
The configuration itself is applied for VDC. It has a few rudimentary settings for NSX-V, which are not the scope of this PR and not tested (still should be working for those who can benefit from them in NSX-V world).
The code itself contains API elevation for API 36.2+ (VCD 10.3.2+) where two new configurations appeared - vApp and VDC Segment Profile templates. They also remain untested here as we don't yet have support for them in SDK and the goal of this PR is to add support for NSX-T Edge Cluster assignment to VDC (field
ServicesEdgeCluster)Additionally code for retrieving NSX-T Edge Clusters was improved:
vdc.GetAllNsxtEdgeClustershas changed the code to use filtering fieldorgVdcIdinstead of deprecated_contextfield.VCDClient.GetAllNsxtEdgeClusterswhich are not bound to VDC. They accept customer filter, which can be defined by consumer. NSX-T Edge Clusters can be filtered by Org VDC (orgVdcId), VDC Group ID (vdcGroupId), and Provider VDC ID (pvdcId)