Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catalog subscription #511

Merged
merged 30 commits into from
Nov 14, 2022
Merged

Catalog subscription #511

merged 30 commits into from
Nov 14, 2022

Conversation

dataclouder
Copy link
Contributor

Addresses Issue #776.

Add methods to create a catalog by subscribing to a published one.
Add methods to synchronise a subscribed catalog and its items .
Add methods to handle lists of tasks, which are useful when starting synchronisation operations in multiple objects, and monitoring the whole effects later.

(Replaces PR #508)

Giuseppe Maxia added 10 commits October 13, 2022 09:03
* ResourceInProgress and ResourceComplete check whether a set of tasks
  for a given resource is in progress
* SkimTasksList and client.SkimTasksList remove completed tasks from a list
* WaitTaskListCompletion and WaitTaskListCompletionMonitor wait for the
  completion of a list of tasks
* client.GetTaskByHREF and client.GetTaskById retrieve a single task by
  ID or HREF

Signed-off-by: Giuseppe Maxia <[email protected]>
Signed-off-by: Giuseppe Maxia <[email protected]>
* Fix field order
* Fix ExpectedSslThumbprint type (string, not bool)

Signed-off-by: Giuseppe Maxia <[email protected]>
Signed-off-by: Giuseppe Maxia <[email protected]>
Giuseppe Maxia added 18 commits October 13, 2022 15:15
Signed-off-by: Giuseppe Maxia <[email protected]>
Signed-off-by: Giuseppe Maxia <[email protected]>
Signed-off-by: Giuseppe Maxia <[email protected]>
Many catalog subscription ops require task management
fine tuning

Signed-off-by: Giuseppe Maxia <[email protected]>
Signed-off-by: Giuseppe Maxia <[email protected]>
Signed-off-by: Giuseppe Maxia <[email protected]>
This upgrade is needed by the usage of `url.JoinPath`, which was
introduced in Go 1.19

Signed-off-by: Giuseppe Maxia <[email protected]>
Signed-off-by: Giuseppe Maxia <[email protected]>
Signed-off-by: Giuseppe Maxia <[email protected]>
@dataclouder dataclouder marked this pull request as ready for review November 8, 2022 07:39
Copy link
Collaborator

@Didainius Didainius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very good. Thanks for cleaning up doc comments.
Majority of my comments are small nits with a few wider queries

Copy link
Collaborator

@adambarreiro adambarreiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for these great features!

Signed-off-by: Giuseppe Maxia <[email protected]>
Copy link
Collaborator

@Didainius Didainius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great implementation, Test took 15m 6s on my machine

@dataclouder dataclouder merged commit b6a9b94 into vmware:main Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants