Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Openapi TestConnection new method #501

Merged
merged 24 commits into from
Aug 29, 2022

Conversation

Didainius
Copy link
Collaborator

@Didainius Didainius commented Aug 25, 2022

This PR builds on top and closes #447, merges with main and adjusts for this development cycle.

Tests passes on 10.3, 10.4

Miguel Sama and others added 22 commits March 10, 2022 12:56
Fix small issue with OpenApiPostItem since it wasnt unmarshalling 200 OK responses

Signed-off-by: Miguel Sama <[email protected]>
Signed-off-by: Miguel Sama <[email protected]>
Signed-off-by: Miguel Sama <[email protected]>
…nt.TestConnection`

Update OpenApiPostItemSync so it supports 200OK codes and now returns error if return code is different from 200 or 201

Signed-off-by: Miguel Sama <[email protected]>
Rename `OpenApiTestConnection` to `TestConnection`

Signed-off-by: Miguel Sama <[email protected]>
Signed-off-by: Miguel Sama <[email protected]>
Signed-off-by: Miguel Sama <[email protected]>
…ApiHighestElevatedVersion`

Signed-off-by: Miguel Sama <[email protected]>
…s` so it test that function and `TestConnection` at the same time

Signed-off-by: Miguel Sama <[email protected]>
Signed-off-by: Miguel Sama <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
@Didainius Didainius marked this pull request as ready for review August 25, 2022 07:40
Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Didainius Didainius merged commit df3370a into vmware:main Aug 29, 2022
@Didainius Didainius deleted the openapi-testconnection-catchup branch August 29, 2022 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants