-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Openapi TestConnection new method #501
Merged
Didainius
merged 24 commits into
vmware:main
from
Didainius:openapi-testconnection-catchup
Aug 29, 2022
Merged
Openapi TestConnection new method #501
Didainius
merged 24 commits into
vmware:main
from
Didainius:openapi-testconnection-catchup
Aug 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miguel Sama <[email protected]>
Signed-off-by: Miguel Sama <[email protected]>
Signed-off-by: Miguel Sama <[email protected]>
Signed-off-by: Miguel Sama <[email protected]>
Fix small issue with OpenApiPostItem since it wasnt unmarshalling 200 OK responses Signed-off-by: Miguel Sama <[email protected]>
Signed-off-by: Miguel Sama <[email protected]>
Signed-off-by: Miguel Sama <[email protected]>
Signed-off-by: Miguel Sama <[email protected]>
Signed-off-by: Miguel Sama <[email protected]>
…nt.TestConnection` Update OpenApiPostItemSync so it supports 200OK codes and now returns error if return code is different from 200 or 201 Signed-off-by: Miguel Sama <[email protected]>
Rename `OpenApiTestConnection` to `TestConnection` Signed-off-by: Miguel Sama <[email protected]>
Signed-off-by: Miguel Sama <[email protected]>
Signed-off-by: Miguel Sama <[email protected]>
…ApiHighestElevatedVersion` Signed-off-by: Miguel Sama <[email protected]>
…ions` Signed-off-by: Miguel Sama <[email protected]>
…ough v36.2 Signed-off-by: Miguel Sama <[email protected]>
Signed-off-by: Miguel Sama <[email protected]>
…efaults Signed-off-by: Miguel Sama <[email protected]>
…s` so it test that function and `TestConnection` at the same time Signed-off-by: Miguel Sama <[email protected]>
Signed-off-by: Miguel Sama <[email protected]>
Signed-off-by: Miguel Sama <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
lvirbalas
approved these changes
Aug 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
adambarreiro
approved these changes
Aug 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on top and closes #447, merges with main and adjusts for this development cycle.
Tests passes on 10.3, 10.4