Add AdminOrgVdcStorageProfile for querying (improved #375) #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added: - QueryResultAdminOrgVdcStorageProfileRecordType type. - Constants for querying: QtOrgVdcStorageProfile and QtAdminOrgVdcStorageProfile. - Funcs for querying : QueryAdminOrgVdcStorageProfileByID and QueryOrgVdcStorageProfileByID. QueryOrgVdcStorageProfileByID (non Admin) not workin (tested wiht vCloud 10.0 and 10.2.2). May be query isn't correct.
- corrected review notes - added point to changelog - update test suit and add test
…now returns only one vdcStorageProfile
…nOrgVdcStorageProfileByID
…rofileRecord # Conflicts: # CHANGELOG.md
updated fields for QueryResultAdminOrgVdcStorageProfileRecordType and QueryResultOrgVdcStorageProfileRecordType add skip/error in case of Client.IsSysAdmin - vmware#384
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
adambarreiro
approved these changes
Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on top of discussions in #375 with test improvement.
Closes #373, #375