Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ResourcePoolRefs read support for AdminVdc type #494

Merged
merged 3 commits into from
Aug 25, 2022

Conversation

Didainius
Copy link
Collaborator

@Didainius Didainius commented Aug 8, 2022

This PR builds on top of #483 to fix the problem with AdminVdc.ResourcePoolRefs read capabilities (this is a read-only field).

There is a Go marshaling problem golang/go#9519 which makes marshaling/unmarshaling non symmetric, but as this field is read-only - we care about reading it.
So the goal is to:

  • Be able to read resources pools backing VDCs
  • Avoid breaking code on create/update operations

Test go test -tags "org vdc" -check.vv -timeout=255m . passed

Closes #483

Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
@Didainius Didainius marked this pull request as ready for review August 8, 2022 11:37
Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

Copy link
Collaborator

@adambarreiro adambarreiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Didainius Didainius merged commit f1bd3a0 into vmware:main Aug 25, 2022
@Didainius Didainius deleted the adminvdc-resource-pool-refs branch August 25, 2022 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants