Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump staticcheck to 2022.1 with Go 1.18 support #457

Merged
merged 2 commits into from
Apr 4, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .changes/v2.15.0/457-notes.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
* Bump `staticcheck` version to 2022.1 with Go 1.18 support [GH-457]
2 changes: 1 addition & 1 deletion govcd/api.go
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ func (client *Client) newRequest(params map[string]string, notEncodedParams map[

// Merge in additional headers before logging if any where specified in additionalHeader
// parameter
if additionalHeader != nil && len(additionalHeader) > 0 {
if len(additionalHeader) > 0 {
for headerName, headerValueSlice := range additionalHeader {
for _, singleHeaderValue := range headerValueSlice {
req.Header.Add(headerName, singleHeaderValue)
Expand Down
2 changes: 1 addition & 1 deletion scripts/staticcheck-config.sh
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
export STATICCHECK_URL=https://github.com/dominikh/go-tools/releases/download
export STATICCHECK_VERSION=2021.1.1
export STATICCHECK_VERSION=2022.1
export STATICCHECK_FILE=staticcheck_linux_amd64.tar.gz