Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new wrappers functions for IP Set using VDC Groups #451

Merged
merged 33 commits into from
Mar 31, 2022
Merged

Add new wrappers functions for IP Set using VDC Groups #451

merged 33 commits into from
Mar 31, 2022

Conversation

vbauzys
Copy link
Contributor

@vbauzys vbauzys commented Mar 29, 2022 •
edited
Loading

Changes for terraform - new functions added:

  • VdcGroup.GetNsxtFirewallGroupById
  • VdcGroup.GetNsxtFirewallGroupByName

Test with 10.3.1 and 10.2.2

vbauzys and others added 28 commits August 25, 2020 08:55
@vbauzys
add main implementation
d05517b
@vbauzys
git push origin master
3faee0a 
Merge branch 'master' of github.com:vmware/go-vcloud-director
@vbauzys
git push origin master
a497ca1 
Merge branch 'master' of github.com:vmware/go-vcloud-director
@vbauzys
git push origin master
71d524d 
Merge branch 'master' of github.com:vmware/go-vcloud-director
@vbauzys
Merge branch 'master' of github.com:vmware/go-vcloud-director
879296d 
# Conflicts:
#	govcd/api.go
#	govcd/api_vcd_test.go
#	govcd/openapi_endpoints.go
#	types/v56/constants.go
#	types/v56/openapi.go
@vbauzys
git push origin masterMerge branch 'master' of github.com:vmware/go-v…
02a4d81 
…cloud-director
@vbauzys
git push origin masterMerge branch 'master' of github.com:vmware/go-v…
b365d6c 
…cloud-director
@vbauzys
removed not needed after merge
808752b
@vbauzys
git push origin masterMerge branch 'master' of github.com:vmware/go-v…
29c17ae 
…cloud-director
@vbauzys
git push origin masterMerge branch 'master' of github.com:vmware/go-v…
9073403 
…cloud-director
@vbauzys
Merge branch 'vmware:master' into master
9efad14
@vbauzys
git push origin masterMerge branch 'master' of github.com:vmware/go-v…
dabfd82 
…cloud-director
@vbauzys
Merge branch 'master' of github.com:vmware/go-vcloud-director
be532a2
@vbauzys
git push origin masterMerge branch 'master' of github.com:vmware/go-v…
6cf856a 
…cloud-director
@vbauzys
Merge branch 'master' of github.com:vmware/go-vcloud-director
144ef18
@vbauzys
Merge branch 'master' of github.com:vmware/go-vcloud-director
8c0217f
@vbauzys
Merge branch 'master' of github.com:vmware/go-vcloud-director
05ac73e
@vbauzys
Merge branch 'master' of github.com:vmware/go-vcloud-director
9056c05
@vbauzys
Merge branch 'master' of github.com:vmware/go-vcloud-director
cb919b2
@vbauzys
Merge branch 'master' of github.com:vmware/go-vcloud-director
253df2d
@vbauzys
Merge branch 'master' of github.com:vmware/go-vcloud-director
a1bccce
@vbauzys
Merge branch 'master' of github.com:vmware/go-vcloud-director
2fa708c
@vbauzys
Merge branch 'main' of github.com:vmware/go-vcloud-director into main
5161390
@vbauzys
Merge branch 'main' of github.com:vmware/go-vcloud-director into main
7c0cf81
@vbauzys
Merge branch 'main' of github.com:vmware/go-vcloud-director into main
cf4c3fe
@vbauzys
Merge branch 'main' of github.com:vmware/go-vcloud-director into main
f7be576
@vbauzys
Merge branch 'main' of github.com:vmware/go-vcloud-director into main
f672000
@vbauzys
add new wrappers and test
5fa3357
@vbauzys vbauzys requested review from dataclouder and removed request for dataclouder March 29, 2022 08:58
@vbauzys vbauzys changed the title Add new wrappers functions for IP set for VDC groups Add new wrappers functions for IP set using VDC groups Mar 29, 2022
@vbauzys vbauzys changed the title Add new wrappers functions for IP set using VDC groups Add new wrappers functions for IP Set using VDC groups Mar 29, 2022
@vbauzys vbauzys changed the title Add new wrappers functions for IP Set using VDC groups Add new wrappers functions for IP Set using VDC Groups Mar 29, 2022
@vbauzys vbauzys marked this pull request as ready for review March 29, 2022 09:08
@vbauzys vbauzys self-assigned this Mar 29, 2022
@vbauzys vbauzys removed the request for review from dataclouder March 29, 2022 09:08
lvirbalas
lvirbalas approved these changes Mar 29, 2022
View reviewed changes
Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see a small PR for a change :) Just one ask.

adambarreiro
adambarreiro approved these changes Mar 29, 2022
View reviewed changes
Copy link
Collaborator

@adambarreiro adambarreiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@vbauzys vbauzys mentioned this pull request Mar 29, 2022
Merged
Didainius
Didainius approved these changes Mar 29, 2022
View reviewed changes
Copy link
Collaborator

@Didainius Didainius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - tests worked on 10.2.0 and 10.3.2

mikeletux
mikeletux approved these changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@mikeletux mikeletux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Approved!

@vbauzys vbauzys merged commit f7c5c53 into vmware:main Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adambarreiro adambarreiro adambarreiro approved these changes

@mikeletux mikeletux mikeletux approved these changes

@lvirbalas lvirbalas lvirbalas approved these changes

@Didainius Didainius Didainius approved these changes

Assignees

@vbauzys vbauzys

Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vbauzys @adambarreiro @mikeletux @lvirbalas @Didainius @vmwclabot