Add Org VDC network support for NSX-T VDC Groups #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dainius Serplis <[email protected]>
Didainius
force-pushed
the
pr-vdc-grp-org-network
branch
from
3695df7 to
b189add
Compare
Signed-off-by: Dainius Serplis <[email protected]>
Didainius
changed the title
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Didainius
requested review from
dataclouder
and removed request for
dataclouder
Didainius
requested review from
lvirbalas,
dataclouder,
vbauzys,
mikeletux and
adambarreiro
as code owners
vbauzys
approved these changes
Mar 21, 2022
lvirbalas
reviewed
Mar 22, 2022
adambarreiro
approved these changes
Mar 22, 2022
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
mikeletux
reviewed
Mar 22, 2022
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
lvirbalas
approved these changes
Mar 23, 2022
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR works to add support for NSX-T VDC Groups in Org VDC networks (routed, isolated and imported).
It also adds a new type
AnyTypeEdgeGatewayand methodsAdminOrg.GetAnyTypeEdgeGatewayById,Org.GetAnyTypeEdgeGatewayById,AnyTypeEdgeGateway.IsNsxt,AnyTypeEdgeGateway.GetNsxtEdgeGateway.Type
AnyTypeEdgeGatewayuses the same structureOpenAPIEdgeGatewaywhich NSX-T Cousin type uses, butAnyTypeEdgeGatewayGetmethods will retrieve both - NSX-T and NSX-V Edge gateways. This is required as a convenience functions of Org VDC network routed network (because it can be backed by NSX-T or NSX-V).Also adds some additional convenience functions: and methods:
VdcGroup.GetNsxtImportableSwitchByName(similar toVdc.GetNsxtImportableSwitchByName)Org.GetOpenApiOrgVdcNetworkByNameAndOwnerIdVdcGroup.GetOpenApiOrgVdcNetworkByNameVdcGroup.GetAllOpenApiOrgVdcNetworksVdcGroup.GetCapabilitiesVdcGroup.IsNsxt