Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metadata support for VDC networks #442

Merged
merged 13 commits into from
Mar 24, 2022

Conversation

adambarreiro
Copy link
Collaborator

@adambarreiro adambarreiro commented Mar 3, 2022

Description

Adds metadata support for VDC networks with CRUD functions.

abarreiro added 2 commits March 3, 2022 15:35
Fix
Signed-off-by: abarreiro <[email protected]>
abarreiro added 3 commits March 3, 2022 15:50
Signed-off-by: abarreiro <[email protected]>
#
Signed-off-by: abarreiro <[email protected]>
fmt
Signed-off-by: abarreiro <[email protected]>
@adambarreiro adambarreiro self-assigned this Mar 3, 2022
@adambarreiro adambarreiro marked this pull request as ready for review March 3, 2022 14:52
@adambarreiro adambarreiro requested review from mikeletux and removed request for dataclouder and vbauzys March 3, 2022 14:52
Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one polishing nit and LGTM!

Copy link
Collaborator

@Didainius Didainius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@mikeletux mikeletux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Approved! Thanks @adambarreiro , great work!

Copy link
Contributor

@vbauzys vbauzys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
It's worth mentioning, that AddMetadataEntry signature changed.

@adambarreiro adambarreiro merged commit 169985e into vmware:main Mar 24, 2022
@adambarreiro adambarreiro deleted the add-metadata-networks branch March 24, 2022 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants