Catalog.QueryMediaList bugfix #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 2, 2022 17:09
Signed-off-by: Miguel Sama <[email protected]>
Add test for Catalog.QueryMediaList and Catalog.QueryVappTemplateList Signed-off-by: Miguel Sama <[email protected]>
mikeletux
requested review from
lvirbalas,
dataclouder,
Didainius and
vbauzys
as code owners
Signed-off-by: Miguel Sama <[email protected]>
lvirbalas
approved these changes
Mar 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Catalog.QueryMediaListmethod has a bug which prevents from correctly retrieve media list from a given catalog.Detailed description
While developing some features for the Terraform provider for VCD, I've found out that the method
Catalog.QueryMediaListwas buggy.When executing it, it throws an error saying that the URL cannot be parsed.
After some debugging, I saw that the method fmt.Sprintf was being used wrongly:
This was causing that the string returned, instead of having escaped characters appropriately, it contained things like
(INVALID)which were crashing the execution.I fix the issue with the following change:
Now things are working properly. Also I saw neither
Catalog.QueryMediaListnorCatalog.QueryVappTemplateListhad tests, so I wrote them! 🚀