Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metadata functions for organizations and independent disks #438

Merged

Conversation

adambarreiro
Copy link
Collaborator

@adambarreiro adambarreiro commented Feb 21, 2022

Description

This PR adds CRUD metadata methods for the AdminOrg, and Disk types.

abarreiro added 4 commits February 21, 2022 14:21
#
Signed-off-by: abarreiro <[email protected]>
#
Signed-off-by: abarreiro <[email protected]>
#
Signed-off-by: abarreiro <[email protected]>
abarreiro added 3 commits February 21, 2022 15:13
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
@adambarreiro adambarreiro self-assigned this Feb 22, 2022
Signed-off-by: abarreiro <[email protected]>
@adambarreiro adambarreiro changed the title Add metadata functions for organizations, independent disks and vApp templates Add metadata functions for organizations and independent disks Feb 22, 2022
abarreiro added 3 commits February 23, 2022 15:08
Signed-off-by: abarreiro <[email protected]>
@adambarreiro adambarreiro marked this pull request as ready for review February 23, 2022 14:17
Copy link
Collaborator

@Didainius Didainius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Signed-off-by: abarreiro <[email protected]>
@adambarreiro
Copy link
Collaborator Author

Added also a function to get metadata from a regular Organization. Updated the tests accordingly.

Signed-off-by: abarreiro <[email protected]>
Copy link
Contributor

@mikeletux mikeletux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Approved :) Thanks @adambarreiro !

@adambarreiro adambarreiro merged commit 179b246 into vmware:main Mar 7, 2022
@adambarreiro adambarreiro deleted the add-metadata-org-disk-vapptempl branch March 7, 2022 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants