Fix issue when internal disk update would clean VM description #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge branch 'master' of github.com:vmware/go-vcloud-director
Merge branch 'master' of github.com:vmware/go-vcloud-director
Merge branch 'master' of github.com:vmware/go-vcloud-director
# Conflicts: # govcd/api.go # govcd/api_vcd_test.go # govcd/openapi_endpoints.go # types/v56/constants.go # types/v56/openapi.go
…clean VM description
vbauzys
requested review from
dataclouder,
Didainius and
lvirbalas
as code owners
|
Looks like this PR contains other PRs, hence is not reviewable in this state. |
# Conflicts: # .changes/v2.14.0/410-features.md # govcd/openapi.go # govcd/tenant_context.go # govcd/vdc_group.go # govcd/vdc_group_test.go
|
Ready for review |
lvirbalas
reviewed
Dec 20, 2021
I am not aware of any anymore. |
lvirbalas
approved these changes
Dec 20, 2021
lvirbalas
reviewed
Dec 20, 2021
lvirbalas
reviewed
Dec 20, 2021
dataclouder
reviewed
Dec 20, 2021
.changes/v2.14.0/418-bug-fixes.md
Outdated
| @@ -0,0 +1,2 @@ | |||
| * Fix Issue #728: `vm.UpdateInternalDisksAsync()` didn't send VM description and as result would delete it [GH-418] | |||
There was a problem hiding this comment.
It's not clear what "it" refers to ("would delete it").
Also, from the conversation in Issue #728, it doesn't seem that this fix addresses that problem.
There was a problem hiding this comment.
yes, it is not 100% as I had very limited information
dataclouder
approved these changes
Dec 20, 2021
Didainius
approved these changes
Dec 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #728
This fix solves the issue when in terraform VM and internal disk resources are used and internal disk update happens (like resize). So on the second terrafom apply VM description is missing and an update on VM is initiated. Also which currently requires VM power off and power on.