Introduce ALB Virtual Service management functions #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
…Name' for easier lookup with Tenant access Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Didainius
requested review from
dataclouder,
lvirbalas and
vbauzys
as code owners
lvirbalas
approved these changes
Dec 17, 2021
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
vbauzys
approved these changes
Dec 20, 2021
|
|
||
| for _, serviceEngineGroupAssignment := range allServiceEngineGroupAssignments { | ||
| if serviceEngineGroupAssignment.NsxtAlbServiceEngineGroupAssignment.ServiceEngineGroupRef.Name == name { | ||
| foundGroup = serviceEngineGroupAssignment |
There was a problem hiding this comment.
Is the name unique? in case we don't return only first one found
There was a problem hiding this comment.
It must be unique:
dataclouder
approved these changes
Dec 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note Only to be reviewed once #414 is merged (because it contains and relies on that code).
This PR adds methods and types to deal with NSX-T ALB Virtual Services.