Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for managing VDC group #410

Merged
merged 50 commits into from
Dec 20, 2021
Merged

Add support for managing VDC group #410

merged 50 commits into from
Dec 20, 2021

Conversation

vbauzys
Copy link
Contributor

@vbauzys vbauzys commented Nov 23, 2021 •
edited
Loading

Added types:

  • VdcGroup
  • types.VdcGroup
  • types.ParticipatingOrgVdcs
  • types.CandidateVdc
  • types.DfwPolicies
  • types.DefaultPolicy
    Added methods:
  • adminOrg.CreateNsxtVdcGroup
  • adminOrg.CreateVdcGroup
  • adminOrg.GetAllNsxtVdcGroupCandidates
  • adminOrg.GetAllVdcGroupCandidates
  • adminOrg.GetAllVdcGroups
  • adminOrg.GetVdcGroupByName
  • adminOrg.GetVdcGroupById
  • vdcGroup.Update
  • vdcGroup.GenericUpdate
  • vdcGroup.Delete
  • vdcGroup.DisableDefaultPolicy
  • vdcGroup.EnableDefaultPolicy
  • vdcGroup.GetDfwPolicies
  • vdcGroup.DeActivateDfw
  • vdcGroup.ActivateDfw
  • vdcGroup.UpdateDefaultDfwPolicies
  • vdcGroup.UpdateDfwPolicies

Verified by 10.2.0 and 10.3.1

vbauzys and others added 16 commits August 25, 2020 08:55
@vbauzys
add main implementation
d05517b
@vbauzys
git push origin master
3faee0a 
Merge branch 'master' of github.com:vmware/go-vcloud-director
@vbauzys
git push origin master
a497ca1 
Merge branch 'master' of github.com:vmware/go-vcloud-director
@vbauzys
git push origin master
71d524d 
Merge branch 'master' of github.com:vmware/go-vcloud-director
@vbauzys
Merge branch 'master' of github.com:vmware/go-vcloud-director
879296d 
# Conflicts:
#	govcd/api.go
#	govcd/api_vcd_test.go
#	govcd/openapi_endpoints.go
#	types/v56/constants.go
#	types/v56/openapi.go
@vbauzys
git push origin masterMerge branch 'master' of github.com:vmware/go-v…
02a4d81 
…cloud-director
@vbauzys
git push origin masterMerge branch 'master' of github.com:vmware/go-v…
b365d6c 
…cloud-director
@vbauzys
removed not needed after merge
808752b
@vbauzys
git push origin masterMerge branch 'master' of github.com:vmware/go-v…
29c17ae 
…cloud-director
@vbauzys
git push origin masterMerge branch 'master' of github.com:vmware/go-v…
9073403 
…cloud-director
@vbauzys
Merge branch 'vmware:master' into master
9efad14
@vbauzys
git push origin masterMerge branch 'master' of github.com:vmware/go-v…
dabfd82 
…cloud-director
@vbauzys
Merge branch 'master' of github.com:vmware/go-vcloud-director
be532a2
@vbauzys
Add VDC group implementation and tests
3b0ef91
@vbauzys
git push origin masterMerge branch 'master' of github.com:vmware/go-v…
6cf856a 
…cloud-director
@vbauzys
Merge branch 'master' into vdc-group
a0978f6
@vbauzys vbauzys self-assigned this Nov 23, 2021
@mkriegs mkriegs mentioned this pull request Nov 28, 2021
Closed
@vbauzys vbauzys marked this pull request as ready for review December 8, 2021 12:05
@vbauzys vbauzys mentioned this pull request Dec 8, 2021
Merged
Didainius
Didainius requested changes Dec 10, 2021
View reviewed changes
Copy link
Collaborator

@Didainius Didainius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pass one. This looks good, mainly minor thoughts here. I will revisit after I do a pass on Terraform.

Tests for vdcGroup tag passed on 10.2

@vbauzys vbauzys changed the title Add suppoert for managing Vdc group Add suppoert for managing VDC group Dec 14, 2021
Didainius
Didainius approved these changes Dec 15, 2021
View reviewed changes
Copy link
Collaborator

@Didainius Didainius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass, I am approving with this conversation remaining - #410 (comment)

@vbauzys vbauzys changed the title Add suppoert for managing VDC group Add support for managing VDC group Dec 15, 2021
lvirbalas
lvirbalas requested changes Dec 15, 2021
View reviewed changes
dataclouder
dataclouder suggested changes Dec 16, 2021
View reviewed changes
@vbauzys vbauzys merged commit 56572c4 into vmware:master Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Didainius Didainius Didainius approved these changes

@lvirbalas lvirbalas lvirbalas approved these changes

@dataclouder dataclouder dataclouder approved these changes

Assignees

@vbauzys vbauzys

Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vbauzys @lvirbalas @dataclouder @Didainius @vmwclabot