Add NSX-T ALB provider configuration support #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dainius Serplis <[email protected]>
Didainius
force-pushed
the
nsxt_alb_clouds-pr
branch
from
f7ded53 to
da1ea33
Compare
Signed-off-by: Dainius Serplis <[email protected]>
Didainius
force-pushed
the
nsxt_alb_clouds-pr
branch
from
da1ea33 to
3cf20db
Compare
Didainius
commented
Sep 6, 2021
| @@ -494,7 +494,7 @@ func (client *Client) OpenApiDeleteItem(apiVersion string, urlRef *url.URL, para | |||
| // OpenApiPostItemAsync, OpenApiPostItem, OpenApiPutItemSync, OpenApiPutItemAsync, OpenApiPutItem | |||
| func (client *Client) openApiPerformPostPut(httpMethod string, apiVersion string, urlRef *url.URL, params url.Values, payload interface{}, additionalHeader map[string]string) (*http.Response, error) { | |||
| // Marshal payload if we have one | |||
| var body *bytes.Buffer | |||
| body := new(bytes.Buffer) | |||
There was a problem hiding this comment.
This change is required so that ==nil evaluation works well when an empty body is being sent.
var body *bytes.buffer (!= nil)
new(bytes.Buffer) == nil
Signed-off-by: Dainius Serplis <[email protected]>
lvirbalas
reviewed
Sep 8, 2021
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
dataclouder
approved these changes
Sep 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Provider part of NSX-T ALB configuration functions. These are required to configure VCD for usage of AVI load balancer (NSX-T ALB)
Functionality includes 5 entities in total. 3 of them have CRUD functionality (some still do not support Update in VCD) and 2 Read-only entities used only for lookup of AVI Controller components for mapping in VCD.
Note. This functionality requires VCD >= 10.2
Testing configuration adds 4 new config parameters