Fix receiver name in client and comments #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@crashiura, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction. |
crashiura
changed the title
Didainius
reviewed
May 28, 2021
Co-authored-by: Dainius <[email protected]>
Co-authored-by: Dainius <[email protected]>
Co-authored-by: Dainius <[email protected]>
Co-authored-by: Dainius <[email protected]>
Co-authored-by: Dainius <[email protected]>
Co-authored-by: Dainius <[email protected]>
Co-authored-by: Dainius <[email protected]>
Fix comments Co-authored-by: Dainius <[email protected]>
|
Thank you for comments, I ran unit tests |
Didainius
approved these changes
May 30, 2021
…rector into fix-func-receiver
|
I added comment in changelog. |
|
@crashiura, VMware has approved your signed contributor license agreement. |
lvirbalas
reviewed
Jun 2, 2021
Co-authored-by: lvirbalas <[email protected]>
lvirbalas
approved these changes
Jun 2, 2021
|
@dataclouder check pls |
dataclouder
suggested changes
Jun 17, 2021
Co-authored-by: Giuseppe Maxia <[email protected]>
Co-authored-by: Giuseppe Maxia <[email protected]>
|
@dataclouder done |
|
@dataclouder Hi, check pls |
dataclouder
approved these changes
Sep 8, 2021
dataclouder
pushed a commit
to dataclouder/go-vcloud-director
that referenced
this pull request
Oct 6, 2021
Signed-off-by: Giuseppe Maxia <[email protected]>
dataclouder
added a commit
that referenced
this pull request
Oct 8, 2021
Signed-off-by: Giuseppe Maxia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a trivial fix so there is no related Issue
I added comments and fixed receiver name in client.