Introduce OpenAPI based Org VDC network management functions for NSX-V and NSX-T #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… -> nsxtImportSegment
lvirbalas
requested changes
Feb 2, 2021
govcd/openapi_org_network.go
Outdated
| } | ||
|
|
||
| if len(allEdges) < 1 { | ||
| return nil, fmt.Errorf("%s: got 0 Org Vdc network by name '%s'", ErrorEntityNotFound, name) |
There was a problem hiding this comment.
Suggested change
| return nil, fmt.Errorf("%s: got 0 Org Vdc network by name '%s'", ErrorEntityNotFound, name) | |
| return nil, fmt.Errorf("%s: got zero Org Vdc networks by name '%s'", ErrorEntityNotFound, name) |
govcd/openapi_org_network.go
Outdated
| case "": | ||
| queryParameters.Set("pageSize", "32") | ||
|
|
||
| // If pageSize is specified ensure it is not >32 |
There was a problem hiding this comment.
This comment seems misplaced.
There was a problem hiding this comment.
This is in correct place. I might need to improve the comment then. The point is that above case "" sets pageSize to 32 if none was specified.
The default case will check what value was provided and if it is >32 it will set it to 32. This is needed because this particular endpoint throws an ugly error if pageSize>32
There was a problem hiding this comment.
Ah, so then the indentation is too big, as it should be inline with default: as right now it looks as if the comment belongs to the case "":
dataclouder
approved these changes
Feb 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces:
OpenApiOrgVdcNetworkstructure and type meant to handle Org VDC networks for both NSX-T and NSX-V backed.NsxtImportableSwitchmeant for lookup "importable switches" (NSX-T segments) to be used for NSX-T Imported networks. MethodsGetNsxtImportableSwitchByNameandGetAllNsxtImportableSwitchesaid thatvdc.IsNsxtandvdc.IsNsxvhelp to verify which type of network provider this VDC is backed.Additionally it ads:
TestVCDstruct for testingedgeGateway(to use existing edge gateway) andunusedSegmentwhich is needed to test our Imported NSX-T Org VDC network