Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VCD version #339

Merged
merged 5 commits into from
Oct 27, 2020
Merged

VCD version #339

merged 5 commits into from
Oct 27, 2020

Conversation

dataclouder
Copy link
Contributor

@dataclouder dataclouder commented Oct 25, 2020 •
edited
Loading

Add functions to retrieve and compare VCD version
client.GetVcdVersion
client.GetVcdShortVersion
client.GetVcdFullVersion
client.VersionEqualOrGreater

These functions do not replace the functions used to compare API versions, which continue having its use.
The main uses of these functions are:

  • Accessing the VCD version through API, and displaying it in logs, test output, diagnostics.
  • Comparing the current version with a given (precise) version, in cases when the API version proves to be too broad (e.g. when a bug fix is introduced in a minor or revision version, and we want to change behavior based on such fix)

@dataclouder dataclouder marked this pull request as ready for review October 25, 2020 21:33
vbauzys
vbauzys approved these changes Oct 26, 2020
View reviewed changes
Copy link
Contributor

@vbauzys vbauzys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lvirbalas
lvirbalas approved these changes Oct 27, 2020
View reviewed changes
Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please add a sentence to PR description and merge message how what we had before was not enough.

@dataclouder
Copy link
Contributor Author

LGTM! Please add a sentence to PR description and merge message how what we had before was not enough.

Added

@dataclouder dataclouder merged commit daf7f4f into vmware:master Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lvirbalas lvirbalas lvirbalas approved these changes

@Didainius Didainius Didainius approved these changes

@vbauzys vbauzys vbauzys approved these changes

Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dataclouder @lvirbalas @Didainius @vbauzys @vmwclabot