-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce NSX-T support for Org Vdc #332
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Tests were successful with 10.1 and 10.2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it mean that tests decides to run or not only by configuration exist or not - is there isn't why to check if VCD backed by NSXT or not?
Well yes. Configuration does hint if we are to do NSX-T related tests or not. Environments can have NSX-T and NSX-V backed VCs. Picking something by default could be risky. |
I was picking the case were I can have configuration but env doens't have NSX-T. |
Well. It will fail very quickly if it doesn't exist. |
We agreed that it will fail for now. We might improve it as we follow NSX-T implementation path for other resources. |
This PR lays some groundwork to introduce NSX-T support in testing. Org Vdc API calls are still using legacy API in UI and it does work properly with API v32.0. The main work here is to add some tests and configuration capability to set NSX-T related resources (network pool, provider vdc).