Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New functionality for handling vApp network static routing #318

Merged
merged 38 commits into from
Jun 26, 2020
Merged

New functionality for handling vApp network static routing #318

merged 38 commits into from
Jun 26, 2020

Conversation

vbauzys
Copy link
Contributor

@vbauzys vbauzys commented Jun 18, 2020

Add function needed for implementing vApp network static routing rules resource:

vapp.UpdateNetworkStaticRouting
vapp.UpdateNetworkStaticRoutingAsync
vapp.RemoveAllNetworkStaticRoutes

This PR is derived from #308 and #316 so shows that PR code too.

vbauzys added 29 commits May 21, 2020 15:02
@vbauzys
Add new functions for vap network and firewall
19e5916
@vbauzys
add change log
2d10f82
@vbauzys
Merge branch 'master' into vapp-fw
9590ff2 
# Conflicts:
#	CHANGELOG.md
@vbauzys
improvements
36813b3
@vbauzys
add comment
77449ee
@vbauzys
add comment
82499b4
@vbauzys
Merge branch 'master' into vapp-fw
5f6d194 
# Conflicts:
#	CHANGELOG.md
@vbauzys
Merge branch 'master' into vapp-fw
8f3ec68 
# Conflicts:
#	CHANGELOG.md
@vbauzys
Add first implementation
368dfa8
@vbauzys
Improve log messages
1361ebf
@vbauzys
Add improvements
3cc1ef7
@vbauzys
Add improvements
46cc77a
@vbauzys
Add improvements
8f96e92
@vbauzys
Merge branch 'vapp-fw' into vapp-nat
b428f44 
# Conflicts:
#	govcd/vapp_network_test.go
@vbauzys
Added implementation for manage vApp nat rules
7ac3fc0
@vbauzys
Add change log
8510b70
@vbauzys
Improvements
8b2974f
@vbauzys
Merge branch 'master' into vapp-nat
c290d0c 
# Conflicts:
#	CHANGELOG.md
#	govcd/vapp_network.go
#	govcd/vapp_network_test.go
#	types/v56/types.go
@vbauzys
Improvements. Also added new function Remove all fw ant nat rules
7ffc899
@vbauzys
Fix comment
cf38695
@vbauzys
Improved handling of IDs
e0c9ba0
@vbauzys
Improve comments
75e3ea6
@vbauzys
Remove not needed code
2142b7e
@vbauzys
Merge branch 'master' into vapp-fw
128ad43 
# Conflicts:
#	CHANGELOG.md
#	types/v56/constants.go
@vbauzys
Merge branch 'master' into vapp-nat
12c89e6 
# Conflicts:
#	govcd/common_test.go
#	govcd/lb_test.go
#	govcd/vm_test.go
@vbauzys
fix after merge
1344a20
@vbauzys
add implementation and test
1b98a6c
@vbauzys
Merge branch 'vapp-fw' into vapp-routing
57347bb 
# Conflicts:
#	types/v56/types.go
@vbauzys
Add check for vApp network
027a8f0
@vbauzys vbauzys requested a review from dataclouder June 18, 2020 10:11
@vbauzys vbauzys requested review from lvirbalas and removed request for dataclouder June 18, 2020 10:11
@vbauzys vbauzys self-assigned this Jun 18, 2020
@vbauzys vbauzys requested a review from dataclouder June 18, 2020 10:11
@vbauzys vbauzys mentioned this pull request Jun 18, 2020
Merged
@vbauzys
Merge branch 'master' into vapp-routing
b94e1a4 
# Conflicts:
#	CHANGELOG.md
#	govcd/vapp_network.go
#	govcd/vapp_network_test.go
#	types/v56/types.go
Didainius
Didainius reviewed Jun 24, 2020
View reviewed changes
Copy link
Collaborator

@Didainius Didainius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - a few considerations inline

lvirbalas
lvirbalas approved these changes Jun 26, 2020
View reviewed changes
Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

dataclouder
dataclouder approved these changes Jun 26, 2020
View reviewed changes
Copy link
Contributor

@dataclouder dataclouder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vbauzys vbauzys merged commit 74c8a0f into vmware:master Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lvirbalas lvirbalas lvirbalas approved these changes

@dataclouder dataclouder dataclouder approved these changes

@Didainius Didainius Didainius approved these changes

Assignees

@vbauzys vbauzys

Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vbauzys @lvirbalas @dataclouder @Didainius @vmwclabot