Do not overwrite log files by default #307
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default
go-vcloud-director
always overwrites log files. This causes problems in some libraries if they instantiatego-vcloud-director
multiple times during single operations run. One example of that being Terraform where it runs plugin 5 times during oneterraform apply
command and part of the logs are instantly overwritten.This PR changes default to "append" instead of overwriting and introduces environment variable
GOVCD_LOG_OVERWRITE
to allow enabling old behavior.