new functions for creation of empty VM #296

vbauzys · 2020-03-30T12:47:32Z

New functions needed implementing empty VM functionality in terraform.

Add empty MV
Query all media is used to find media to attach as boot image
UpdateVmSpecSectionAsync/UpdateVmSpecSection

Signed-off-by: Vaidotas Bauzys <[email protected]>

…cloud-director

Signed-off-by: Vaidotas Bauzys <[email protected]>

Didainius

Thanks. A few questions inline and one below.

Does it satisfy the need to create a VM without having a vApp? If so - I am wondering should the parent be vApp or vDC? (having in mind that there may be no vApp context for user)

govcd/media.go

types/v56/vm_types.go

govcd/vm.go

Signed-off-by: Vaidotas Bauzys <[email protected]>

…cloud-director

Signed-off-by: Vaidotas Bauzys <[email protected]>

…cloud-director

dataclouder

First pass

dataclouder · 2020-04-02T11:06:56Z

CHANGELOG.md

@@ -2,6 +2,7 @@

 * Added methods `OrgVdcNetwork.Update`, `OrgVdcNetwork.UpdateAsync`, and `OrgVdcNetwork.Rename` [#292](https://github.com/vmware/go-vcloud-director/pull/292)
 * Added methods `EdgeGateway.Update` and `EdgeGateway.UpdateAsync` [#292](https://github.com/vmware/go-vcloud-director/pull/292)
+* Added methods `vapp.AddEmptyVm`, `vapp.AddEmptyVmAsync` and vdc.QueryAllMedia [#296](https://github.com/vmware/go-vcloud-director/pull/296)


Suggested change

* Added methods `vapp.AddEmptyVm`, `vapp.AddEmptyVmAsync` and vdc.QueryAllMedia [#296](https://github.com/vmware/go-vcloud-director/pull/296)

* Added methods `vapp.AddEmptyVm`, `vapp.AddEmptyVmAsync` and `vdc.QueryAllMedia` [#296](https://github.com/vmware/go-vcloud-director/pull/296)

dataclouder · 2020-04-02T11:08:08Z

govcd/api.go

@@ -564,3 +564,8 @@ func combinedTaskErrorMessage(task *types.Task, err error) string {
 func takeBoolPointer(value bool) *bool {
 	return &value
 }
+
+// takeIntAddress is a helper which can gives address of `int`


Suggested change

// takeIntAddress is a helper which can gives address of `int`

// takeIntAddress is a helper that returns the address of an `int`

dataclouder · 2020-04-02T11:08:55Z

govcd/media.go

@@ -637,3 +637,42 @@ func (mediaRecord *MediaRecord) Delete() (Task, error) {
 	return mediaRecord.client.ExecuteTaskRequest(mediaRecord.MediaRecord.HREF, http.MethodDelete,
 		"", "error deleting Media item: %s", nil)
 }
+
+// QueryAllMedia returns media image found in system using `name` as query.


Suggested change

// QueryAllMedia returns media image found in system using `name` as query.

// QueryAllMedia returns all media images found in system using `name` as query.

dataclouder · 2020-04-02T11:13:21Z

govcd/media_test.go

+
+	testQueryMediaName := vcd.config.Media.Media
+
+	mediaSlise, err := vcd.vdc.QueryAllMedia(testQueryMediaName)


Suggested change

mediaSlise, err := vcd.vdc.QueryAllMedia(testQueryMediaName)

mediaList, err := vcd.vdc.QueryAllMedia(testQueryMediaName)

dataclouder · 2020-04-02T11:14:34Z

govcd/vm.go

 		}, vm.client.GetSpecificApiVersionOnCondition(">= 32.0", "32.0"))

 }
+
+// AddEmptyVm adds new empty VM (without template) to vApp and returns new created VM or error.


Suggested change

// AddEmptyVm adds new empty VM (without template) to vApp and returns new created VM or error.

// AddEmptyVm adds an empty VM (without template) to vApp and returns the new created VM or an error.

dataclouder · 2020-04-02T11:15:54Z

govcd/vm.go

+
+}
+
+// AddEmptyVmAsync adds new empty VM (without template) to vApp and returns Task or error.


Suggested change

// AddEmptyVmAsync adds new empty VM (without template) to vApp and returns Task or error.

// AddEmptyVmAsync adds an empty VM (without template) to the vApp and returns a Task and an error.

dataclouder · 2020-04-02T11:17:00Z

govcd/vm.go

+		types.MimeRecomposeVappParams, "error instantiating a new VM: %s", reComposeVAppParams)
+}
+
+func validateEmptyVmParams(reComposeVAppParams *types.RecomposeVAppParamsForEmptyVm) error {


Please add description

dataclouder · 2020-04-02T11:23:28Z

govcd/vm_test.go

+	//media, err := cat.GetMediaByName("photon-custom-hw11-2.0-304b817.ova", false)
+	media, err := cat.GetMediaByName("vaido2", false)


hardcoded name. How does this media item become available?

updated. Value comes from configuration

dataclouder · 2020-04-02T11:26:05Z

types/v56/vm_types.go

@@ -0,0 +1,39 @@
+package types


Why a separate file for some VM related types?
If we split by entity, this file should contain all VM types, but then we should have separate files for each entity

I am trying to start splitting by domain(VM/VAPP/EdgeGtw/ etc.). If everyone agrees then it is start to add new one to separate type files. In time we move everything accordingly. I won't do let's split everything now it's to much and not this PR scope, but we can start doing better from today.

Signed-off-by: Vaidotas Bauzys <[email protected]>

…cloud-director

Merge branch 'master' of github.com:vmware/go-vcloud-director

Signed-off-by: Vaidotas Bauzys <[email protected]> # Conflicts: # CHANGELOG.md

Didainius

Tests passed on 9.7, 10.0 and 10.1

dataclouder

LGTM

lvirbalas

LGTM

vbauzys added 4 commits March 23, 2020 14:04

First implementation

66728a2

Signed-off-by: Vaidotas Bauzys <[email protected]>

git push origin masterMerge branch 'master' of github.com:vmware/go-v…

c2d3d04

…cloud-director

Add query all media

27d501b

Signed-off-by: Vaidotas Bauzys <[email protected]>

Add test for QueryAllMedia

81478aa

Signed-off-by: Vaidotas Bauzys <[email protected]>

vmwclabot added the cla-not-required label Mar 30, 2020

Add changelog

0c58666

Signed-off-by: Vaidotas Bauzys <[email protected]>

vbauzys self-assigned this Mar 30, 2020

vbauzys requested review from Didainius, dataclouder and lvirbalas and removed request for Didainius, dataclouder and lvirbalas March 30, 2020 12:49

Didainius reviewed Mar 30, 2020

View reviewed changes

govcd/media.go Show resolved Hide resolved

types/v56/vm_types.go Show resolved Hide resolved

types/v56/vm_types.go Show resolved Hide resolved

govcd/vm.go Outdated Show resolved Hide resolved

vbauzys added 5 commits March 31, 2020 08:20

Add comments

789fe0c

Signed-off-by: Vaidotas Bauzys <[email protected]>

Add validation and comments

dc7383e

Signed-off-by: Vaidotas Bauzys <[email protected]>

git push origin masterMerge branch 'master' of github.com:vmware/go-v…

fbccf97

…cloud-director

Added Update VmSpecSection function

bf3fb66

Signed-off-by: Vaidotas Bauzys <[email protected]>

Improved update functionality

23ef62a

Signed-off-by: Vaidotas Bauzys <[email protected]>

vbauzys mentioned this pull request Apr 1, 2020

Allows to create empty VM vmware/terraform-provider-vcd#484

Merged

vbauzys added 2 commits April 2, 2020 08:47

git push origin masterMerge branch 'master' of github.com:vmware/go-v…

bd3d0e4

…cloud-director

Merge branch 'master' into create-empty-vm

06a8124

dataclouder suggested changes Apr 2, 2020

View reviewed changes

vbauzys added 2 commits April 2, 2020 15:51

Added and update comments

b052718

Signed-off-by: Vaidotas Bauzys <[email protected]>

Improved test

aab45bd

Signed-off-by: Vaidotas Bauzys <[email protected]>

vbauzys added 5 commits April 3, 2020 17:14

Fix type XML ordering

d6e2452

Signed-off-by: Vaidotas Bauzys <[email protected]>

git push origin masterMerge branch 'master' of github.com:vmware/go-v…

4e02eb0

…cloud-director

Merge branch 'master' into create-empty-vm

8cd8c58

git push origin master

3a3b1c6

Merge branch 'master' of github.com:vmware/go-vcloud-director

Merge branch 'master' into create-empty-vm

aaa977b

Signed-off-by: Vaidotas Bauzys <[email protected]> # Conflicts: # CHANGELOG.md

Didainius approved these changes Apr 22, 2020

View reviewed changes

dataclouder approved these changes Apr 23, 2020

View reviewed changes

lvirbalas approved these changes Apr 28, 2020

View reviewed changes

vbauzys merged commit 507d694 into vmware:master Apr 28, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

new functions for creation of empty VM #296

new functions for creation of empty VM #296

vbauzys commented Mar 30, 2020 •

edited

Loading

Didainius left a comment

dataclouder left a comment

dataclouder Apr 2, 2020

vbauzys Apr 2, 2020

dataclouder Apr 2, 2020

vbauzys Apr 2, 2020

dataclouder Apr 2, 2020

vbauzys Apr 2, 2020

dataclouder Apr 2, 2020

vbauzys Apr 2, 2020

dataclouder Apr 2, 2020

vbauzys Apr 2, 2020

dataclouder Apr 2, 2020

vbauzys Apr 2, 2020

dataclouder Apr 2, 2020

vbauzys Apr 2, 2020

dataclouder Apr 2, 2020

vbauzys Apr 2, 2020

dataclouder Apr 2, 2020

vbauzys Apr 2, 2020

Didainius left a comment

dataclouder left a comment

lvirbalas left a comment

	* Added methods `vapp.AddEmptyVm`, `vapp.AddEmptyVmAsync` and vdc.QueryAllMedia [#296](https://github.com/vmware/go-vcloud-director/pull/296)
	* Added methods `vapp.AddEmptyVm`, `vapp.AddEmptyVmAsync` and `vdc.QueryAllMedia` [#296](https://github.com/vmware/go-vcloud-director/pull/296)

	// takeIntAddress is a helper which can gives address of `int`
	// takeIntAddress is a helper that returns the address of an `int`

	// QueryAllMedia returns media image found in system using `name` as query.
	// QueryAllMedia returns all media images found in system using `name` as query.


		testQueryMediaName := vcd.config.Media.Media

		mediaSlise, err := vcd.vdc.QueryAllMedia(testQueryMediaName)

	mediaSlise, err := vcd.vdc.QueryAllMedia(testQueryMediaName)
	mediaList, err := vcd.vdc.QueryAllMedia(testQueryMediaName)

	// AddEmptyVm adds new empty VM (without template) to vApp and returns new created VM or error.
	// AddEmptyVm adds an empty VM (without template) to vApp and returns the new created VM or an error.


		}

		// AddEmptyVmAsync adds new empty VM (without template) to vApp and returns Task or error.

	// AddEmptyVmAsync adds new empty VM (without template) to vApp and returns Task or error.
	// AddEmptyVmAsync adds an empty VM (without template) to the vApp and returns a Task and an error.

		//media, err := cat.GetMediaByName("photon-custom-hw11-2.0-304b817.ova", false)
		media, err := cat.GetMediaByName("vaido2", false)

new functions for creation of empty VM #296

new functions for creation of empty VM #296

Conversation

vbauzys commented Mar 30, 2020 • edited Loading

Didainius left a comment

Choose a reason for hiding this comment

dataclouder left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Didainius left a comment

Choose a reason for hiding this comment

dataclouder left a comment

Choose a reason for hiding this comment

lvirbalas left a comment

Choose a reason for hiding this comment

vbauzys commented Mar 30, 2020 •

edited

Loading