Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List functions #278

Merged
merged 12 commits into from
Jan 20, 2020
Merged

List functions #278

merged 12 commits into from
Jan 20, 2020

Conversation

dataclouder
Copy link
Contributor

@dataclouder dataclouder commented Jan 12, 2020 •
edited
Loading

Add a few functions that are needed for list manipulation in other libraries or applications. (GetVappTemplateByHref and GetEdgeGatewayReferenceList)

Remove unused fields in VCDClient and Vdc.
Export function GetEdgeGatewayByHref

Giuseppe Maxia added 4 commits January 12, 2020 23:47
Remove unused field Mutex from VCDClient
9ac0215
Export functions and clean Vdc structure
d1467ad 
* Remove unused field VApp from Vdc structure
* Make function GetEdgeGatewayByHref public
* Add function GetEdgeGatewayReferenceList
Add function GetVappTemplateByHref
6963f48
Fix somment error
ecc7de7
Didainius
Didainius reviewed Jan 16, 2020
View reviewed changes
Copy link
Collaborator

@Didainius Didainius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog deserves a note :)

Giuseppe Maxia added 3 commits January 16, 2020 11:54
update CHANGELOG.md
42bac4f
Add missing checks for vApp test requirement
25140d8
Simplify query related functions
3b89a6b 
* Replace literal query type with constant
* Remove unnecessary 'name' parameter from GetEdgeGatewayByHref
lvirbalas
lvirbalas approved these changes Jan 17, 2020
View reviewed changes
Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One polishing ask and a LGTM :)

vbauzys
vbauzys suggested changes Jan 17, 2020
View reviewed changes
Copy link
Contributor

@vbauzys vbauzys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First round

Giuseppe Maxia added 2 commits January 17, 2020 13:00
Improve vAppTemplate test
0b74b40
Remove GetEdgeGatewayReferenceList
1fba5bf 
* Make getEdgeGatewayRecordsType public
* Remove now redundant GetEdgeGatewayReferenceList
* Adjust the test to use GetEdgeGatewayRecordsType instead
@dataclouder dataclouder merged commit 5328e0b into vmware:master Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lvirbalas lvirbalas lvirbalas approved these changes

@Didainius Didainius Didainius approved these changes

@vbauzys vbauzys vbauzys approved these changes

Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dataclouder @lvirbalas @Didainius @vbauzys @vmwclabot