Add support for NSX-V Edge Gateway DHCP relay settings #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lvirbalas
reviewed
Dec 5, 2019
CHANGELOG.md
Outdated
| @@ -28,6 +28,8 @@ | |||
| * Added IP set handling functions `CreateNsxvIpSet`, `UpdateNsxvIpSet`, `GetNsxvIpSetByName`, | |||
| `GetNsxvIpSetById`, `GetNsxvIpSetByNameOrId`, `GetAllNsxvIpSets`, `DeleteNsxvIpSetById`, | |||
| `DeleteNsxvIpSetByName` [#269](https://github.com/vmware/go-vcloud-director/pull/269) | |||
| * Added `UpdateDhcpRelay`, `GetDhcpRelay` and `ResetDhcpRelay()` methods for Edge Gatway DHCP relay | |||
There was a problem hiding this comment.
Suggested change
| * Added `UpdateDhcpRelay`, `GetDhcpRelay` and `ResetDhcpRelay()` methods for Edge Gatway DHCP relay | |
| * Added `UpdateDhcpRelay`, `GetDhcpRelay` and `ResetDhcpRelay` methods for Edge Gatway DHCP relay |
It does probably. I got split brain while looking at load balancers. But in the end they don't have NSXV anywhere. Changed. |
dataclouder
reviewed
Dec 9, 2019
| check.Assert(err, IsNil) | ||
|
|
||
| parentEntity = vcd.org.Org.Name + "|" + vcd.vdc.Vdc.Name + "|" + vcd.config.VCD.EdgeGateway | ||
| PrependToCleanupList(check.TestName(), "dhcpRelayConfig", parentEntity, check.TestName()) |
There was a problem hiding this comment.
Please add a comment about using PrependToCleanupList instead of Add, for future reference
vbauzys
approved these changes
Dec 9, 2019
govcd/nsxv_dhcprelay.go
Outdated
Comment on lines
76
to
80
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| return nil |
There was a problem hiding this comment.
just return err is sufficient
There was a problem hiding this comment.
Changed. Although this had its reason. It is about clearly distinguishing the "happy" and "bad" path on function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Edge Gateway DHCP relay setting management using 3 methods:
UpdateDhcpRelay,GetDhcpRelayandResetDhcpRelayNote. Test suite passed on 9.5 and 10.