Add metadata functionality for vAppTemplate and media image/item #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vaidotas Bauzys <[email protected]>
dataclouder
suggested changes
Aug 1, 2019
govcd/metadata.go
Outdated
| return vAppTemplate, nil | ||
| } | ||
|
|
||
| // AddMetadata() function calls private function addMetadata() with vAppTemplate.client and vAppTemplate.VAppTemplate.HREF |
There was a problem hiding this comment.
this comment should say AddMetadataAsync
govcd/metadata.go
Outdated
| } | ||
|
|
||
| // AddMetadata() function calls private function addMetadata() with vAppTemplate.client and vAppTemplate.VAppTemplate.HREF | ||
| // which adds metadata key, value pair provided as input. |
There was a problem hiding this comment.
"key, value" -> "key/value"
govcd/metadata.go
Outdated
| return getMetadata(mediaItem.client, mediaItem.MediaItem.HREF) | ||
| } | ||
|
|
||
| // AddMetadata() function adds metadata key, value pair provided as input. |
There was a problem hiding this comment.
"key, value" -> "key/value"
govcd/metadata.go
Outdated
| } | ||
| err = task.WaitTaskCompletion() | ||
| if err != nil { | ||
| return nil, fmt.Errorf("error completing add metadata for media item task: %#v", err) |
govcd/metadata.go
Outdated
|
|
||
| err = mediaItem.Refresh() | ||
| if err != nil { | ||
| return nil, fmt.Errorf("error refreshing media item: %#v", err) |
|
|
||
| uploadTask, err := catalog.UploadMediaImage(itemName, "upload from test", vcd.config.Media.MediaPath, 1024) | ||
| check.Assert(err, IsNil) | ||
| err = uploadTask.WaitTaskCompletion() |
There was a problem hiding this comment.
task should be checked before usage
|
|
||
| // Check if metadata was added correctly | ||
| metadata, err := mediaItem.GetMetadata() | ||
| check.Assert(err, IsNil) |
There was a problem hiding this comment.
metadata should be also checked
| } | ||
|
|
||
| catItem, err := cat.FindCatalogItem(vcd.config.VCD.Catalog.CatalogItem) | ||
| check.Assert(err, IsNil) |
There was a problem hiding this comment.
catItem should be also checked
|
|
||
| // Get VAppTemplate | ||
| vAppTemplate, err := catItem.GetVAppTemplate() | ||
| check.Assert(err, IsNil) |
There was a problem hiding this comment.
vAppTemplate should be also checked
govcd/vapptemplate_test.go
Outdated
| oldVAppTemplate := vAppTemplate | ||
|
|
||
| err = vAppTemplate.Refresh() | ||
| check.Assert(oldVAppTemplate.VAppTemplate, Equals, vAppTemplate.VAppTemplate) |
Signed-off-by: Vaidotas Bauzys <[email protected]>
Signed-off-by: Vaidotas Bauzys <[email protected]>
Signed-off-by: Vaidotas Bauzys <[email protected]>
Signed-off-by: Vaidotas Bauzys <[email protected]>
lvirbalas
requested changes
Aug 2, 2019
Signed-off-by: Vaidotas Bauzys <[email protected]>
Signed-off-by: Vaidotas Bauzys <[email protected]> # Conflicts: # CHANGELOG.md
Signed-off-by: Vaidotas Bauzys <[email protected]> # Conflicts: # CHANGELOG.md
Signed-off-by: Vaidotas Bauzys <[email protected]>
lvirbalas
approved these changes
Aug 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref:https://github.com/terraform-providers/terraform-provider-vcd/issues/285
Added new CRUD metadata functions for vApp template and media image.
Also new refresh functions for vApp template and media image.
This new functions will be used in terraform to provide resources metadata capabilities.