Add load balancer server pool CRUD #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lvirbalas
requested changes
Jun 20, 2019
dataclouder
suggested changes
Jun 26, 2019
vbauzys
reviewed
Jun 28, 2019
| // Update - change a single field and compare that configuration and result objects are deeply equal | ||
| // Update - try and fail to update without mandatory field | ||
| // Delete | ||
| func (vcd *TestVCD) Test_LBServerPool(check *C) { |
There was a problem hiding this comment.
I am not fond of such unit test where all functionality tested. It more like workflow test and not function unit test. @dataclouder
There was a problem hiding this comment.
I could split them, however this would make total run time longer due to for situations such as Test_ReadLBServerPool, Test_UpdateLBServerPool, Test_DeleteLBServerPool I would still need to create for each scenario.
vbauzys
reviewed
Jun 28, 2019
vbauzys
reviewed
Jun 28, 2019
vbauzys
approved these changes
Jul 1, 2019
There was a problem hiding this comment.
After @dataclouder accepts such test, then PR can be merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of implementing edge gateway load balancers https://github.com/terraform-providers/terraform-provider-vcd/issues/223
This PR introduces load balancer server pool support in govcd.