Introduce vCD API version checks #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Didainius
requested review from
dataclouder and
vbauzys
and removed request for
dataclouder
lvirbalas
reviewed
Apr 8, 2019
dataclouder
reviewed
Apr 8, 2019
govcd/api_vcd_versions.go
Outdated
| // Format: ">= 27.0, < 32.0", ">= 30.0", "= 27.0" | ||
| // | ||
| // vCD version mapping to API version support https://code.vmware.com/doc/preview?id=8072 | ||
| func (vdcCli *VCDClient) APIMaxVerIs(versionConstraint string) bool { |
There was a problem hiding this comment.
It should be vcdCli, not vdcCli.
This error is present in many methods through the library. It would be nice to fix all of them. (I may have been part of the misnaming)
There was a problem hiding this comment.
Ok. It seemed confusing and now I know why. I will fix it either in the end of this PR (to avoid many altered files in PR) or in a separate one.
vbauzys
reviewed
Apr 9, 2019
vbauzys
reviewed
Apr 9, 2019
vbauzys
reviewed
Apr 9, 2019
vbauzys
reviewed
Apr 9, 2019
vbauzys
approved these changes
Apr 9, 2019
dataclouder
suggested changes
Apr 9, 2019
govcd/api_vcd_versions_test.go
Outdated
| var versionTests = []struct { | ||
| version string | ||
| boolChecker Checker | ||
| isSsupported bool |
There was a problem hiding this comment.
typo: isSsupported should be isSupported
govcd/api_vcd_versions_test.go
Outdated
| func (vcd *TestVCD) Test_APIClientVersionIs(check *C) { | ||
|
|
||
| // Check with currently set version | ||
| r := vcd.client.APIClientVersionIs(fmt.Sprintf("= %s", vcd.client.Client.APIVersion)) |
There was a problem hiding this comment.
What does r stand for? Wouldn't be better to use a full word?
There was a problem hiding this comment.
r = result. Sorry, it's that same idiom sitting on me I'm changing it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #173
As we already spotted (#173) sometimes even the same API version on vCD has some differences which caused test suite failures. This PR introduces ability to check on API supported versions using Hashicorp's
go-versionpackage in a friendly manner: "> 27", "=27", ">= 27", etc. It does not directly allow to match vCD product versions (9.x.x), because there is no API to get them.Exported API introduces two methods:
APIMaxVerIsAPIVCDMaxVersionIs(allows to compare against vCD Maximum supported version and is useful to understand which vCD version is running https://code.vmware.com/doc/preview?id=8072)APICurVerIsAPIClientVersionIs(allows to compare against currently used API version)Also introduced a configuration option
WithAPIVersion(version string) VCDClientOptionwhich allows to easily override API version used